Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/closure_compiler/compile_js.gypi

Issue 2117653002: Add the ability to pass arguments to runner.jar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable-chrome-pass
Patch Set: merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/closure_compiler/compile2.py ('k') | third_party/closure_compiler/compile_js2.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/compile_js.gypi
diff --git a/third_party/closure_compiler/compile_js.gypi b/third_party/closure_compiler/compile_js.gypi
index f947c9966f8042ce9f67eb03db924550a47eefef..f718246889bbcaf28a7f072d862bab46fd23c17f 100644
--- a/third_party/closure_compiler/compile_js.gypi
+++ b/third_party/closure_compiler/compile_js.gypi
@@ -32,7 +32,10 @@
'out_file%': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <(_target_name).js)',
'externs%': [],
'depends%': [],
+ 'runner_args%': ['enable-chrome-pass'],
+ # TODO(dbeam): remove when no longer used from remoting/.
'script_args%': [],
+ 'closure_args%': '<(default_closure_args)',
'disabled_closure_args%': '<(default_disabled_closure_args)',
},
'inputs': [
@@ -55,9 +58,10 @@
'<@(script_args)',
'--depends', '<@(depends)',
'--externs', '<@(externs)',
- '--out-file', '<(out_file)',
- '--closure-args', '<@(closure_args)', '<@(disabled_closure_args)',
- # Add '--verbose' for make glorious log spam of Closure compiler.
+ '--out_file', '<(out_file)',
+ '--runner_args', '<@(runner_args)',
+ '--closure_args', '<@(closure_args)', '<@(disabled_closure_args)',
+ # '--verbose' # for make glorious log spam of Closure compiler.
],
'message': 'Compiling <(_target_name)',
}
« no previous file with comments | « third_party/closure_compiler/compile2.py ('k') | third_party/closure_compiler/compile_js2.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698