Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117603002:
Added tests and reworked ink-drop touch logic (Closed)
|
Created:
4 years, 5 months ago by kylix_rd Modified:
4 years, 5 months ago Reviewers:
bruthig CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded tests and reworked ink-drop touch logic
BUG=595315
Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78
Committed: https://crrev.com/2492af4d898c22ca3a341e67cb223e0e7ebabe0c
Cr-Original-Commit-Position: refs/heads/master@{#403462}
Cr-Commit-Position: refs/heads/master@{#403481}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Added test for a gesture event #Patch Set 3 : Fixed merge error & build failure #
Messages
Total messages: 22 (10 generated)
Description was changed from ========== Added tests and reworked ink-drop touch logic BUG= ========== to ========== Added tests and reworked ink-drop touch logic BUG=595315 ==========
kylixrd@chromium.org changed reviewers: + bruthig@chromium.org
Added IsTouchEvent() to the existing IsGestureEvent() portion of the if-statement. Will add more gesture event tests (tap, tap-down). https://codereview.chromium.org/2117603002/diff/1/ui/views/animation/ink_drop... File ui/views/animation/ink_drop_host_view_unittest.cc (right): https://codereview.chromium.org/2117603002/diff/1/ui/views/animation/ink_drop... ui/views/animation/ink_drop_host_view_unittest.cc:24: } Added this override to work around the NOTREACHED statement in the InkDropHosView::GetInkDropBaseColor() base virtual implementation.
I thought about adding a test to DismissInkDropOnTouchOrGestureEvents, but that would be redundant and not actually be testing anything. I only want to ensure that the ink drop state is allowed when the current state is "pending"
lgtm
The CQ bit was checked by kylixrd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Added tests and reworked ink-drop touch logic BUG=595315 ========== to ========== Added tests and reworked ink-drop touch logic BUG=595315 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Added tests and reworked ink-drop touch logic BUG=595315 ========== to ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462}
Message was sent while issue was closed.
On 2016/07/01 16:07:02, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 > Cr-Commit-Position: refs/heads/master@{#403462} I have not yet gotten my committer status. bruthig@, would you be willing to go ahead and merge this up to M53?
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2115933002/ by kelvinp@chromium.org. The reason for reverting is: Compilation failure on Chromium.win builder. https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds....
Message was sent while issue was closed.
Description was changed from ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462} ========== to ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462} ==========
The CQ bit was checked by kylixrd@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bruthig@chromium.org Link to the patchset: https://codereview.chromium.org/2117603002/#ps40001 (title: "Fixed merge error & build failure")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462} ========== to ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Cr-Commit-Position: refs/heads/master@{#403462} ========== to ========== Added tests and reworked ink-drop touch logic BUG=595315 Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 Committed: https://crrev.com/2492af4d898c22ca3a341e67cb223e0e7ebabe0c Cr-Original-Commit-Position: refs/heads/master@{#403462} Cr-Commit-Position: refs/heads/master@{#403481} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2492af4d898c22ca3a341e67cb223e0e7ebabe0c Cr-Commit-Position: refs/heads/master@{#403481}
Message was sent while issue was closed.
On 2016/07/01 16:17:20, kylix_rd wrote: > On 2016/07/01 16:07:02, commit-bot: I haz the power wrote: > > Patchset 2 (id:??) landed as > > https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 > > Cr-Commit-Position: refs/heads/master@{#403462} > > I have not yet gotten my committer status. bruthig@, would you be willing to go > ahead and merge this up to M53? Sure, can you update the bug with the Merge-Request-53 label and enumerate the CL(s) that need to be merged and then you can assign it to me. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
