Porting the toolbar to GTK.

Porting the toolbar to GTK.

Quite a bit of TODOs in the code, but it displays and properly
enables/disables buttons and routes mouse clicks.

This also moves all the gtk files into the gtk/ folder, at Ben's request.

[Evan Martin, 2009-02-09 19:12:35]

rad!

http://codereview.chromium.org/21176/diff/12/1003
File chrome/browser/browser_toolbar_view_gtk.h (right):

http://codereview.chromium.org/21176/diff/12/1003#newcode51
Line 51: GtkButton* back_;
Gtk style normally is to leave variables as a GtkWidget*, and then downcast in
the cases where you need it.  I think it'd actually end up reducing casts in
your code to do it that way.

http://codereview.chromium.org/21176/diff/12/1005
File chrome/browser/browser_window_gtk.h (right):

http://codereview.chromium.org/21176/diff/12/1005#newcode65
Line 65: GtkWidget* vbox_;
Do we need to keep this around as a member?  It seems it's only used in one
function.

[Elliot Glaysher, 2009-02-09 20:12:12]

Can you take another look? Also, rietveld is confused because of the renames.

On 2009/02/09 19:12:35, Evan Martin wrote:
> rad!
> 
> http://codereview.chromium.org/21176/diff/12/1003
> File chrome/browser/browser_toolbar_view_gtk.h (right):
> 
> http://codereview.chromium.org/21176/diff/12/1003#newcode51
> Line 51: GtkButton* back_;
> Gtk style normally is to leave variables as a GtkWidget*, and then downcast in
> the cases where you need it.  I think it'd actually end up reducing casts in
> your code to do it that way.
> 
> http://codereview.chromium.org/21176/diff/12/1005
> File chrome/browser/browser_window_gtk.h (right):
> 
> http://codereview.chromium.org/21176/diff/12/1005#newcode65
> Line 65: GtkWidget* vbox_;
> Do we need to keep this around as a member?  It seems it's only used in one
> function.

[Evan Martin, 2009-02-09 20:15:09]

ship it