Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 21176: Porting the toolbar to GTK. (Closed)

Created:
10 years, 6 months ago by Elliot Glaysher
Modified:
8 years, 3 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Porting the toolbar to GTK. Quite a bit of TODOs in the code, but it displays and properly enables/disables buttons and routes mouse clicks. This also moves all the gtk files into the gtk/ folder, at Ben's request.

Patch Set 1 #

Patch Set 2 : Comments, please. #

Total comments: 2

Patch Set 3 : Move into gtk/ folder at Ben's request. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -300 lines) Patch
M chrome/browser/browser.scons View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/browser_main_gtk.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/browser/browser_window_factory_gtk.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/browser_window_gtk.h View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/browser_window_gtk.cc View 1 2 1 chunk +0 lines, -184 lines 0 comments Download
A chrome/browser/gtk/browser_main_gtk.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/gtk/browser_toolbar_view_gtk.h View 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/gtk/browser_toolbar_view_gtk.cc View 1 chunk +144 lines, -0 lines 0 comments Download
A chrome/browser/gtk/browser_window_factory_gtk.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/gtk/browser_window_gtk.h View 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +193 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
10 years, 6 months ago (2009-02-09 18:53:16 UTC) #1
Evan Martin
rad! http://codereview.chromium.org/21176/diff/12/1003 File chrome/browser/browser_toolbar_view_gtk.h (right): http://codereview.chromium.org/21176/diff/12/1003#newcode51 Line 51: GtkButton* back_; Gtk style normally is to ...
10 years, 6 months ago (2009-02-09 19:12:35 UTC) #2
Elliot Glaysher
Can you take another look? Also, rietveld is confused because of the renames. On 2009/02/09 ...
10 years, 6 months ago (2009-02-09 20:12:12 UTC) #3
Evan Martin
10 years, 6 months ago (2009-02-09 20:15:09 UTC) #4
ship it

Powered by Google App Engine
This is Rietveld 408576698