Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 2117593002: Fuchsia: Initial check-in. (Closed)

Created:
4 years, 5 months ago by zra
Modified:
4 years, 5 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Initial check-in. Instructions to build and run are in README.fuchsia. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a503570e3a72d6bb21b7c98466ba94faef3f3e5a

Patch Set 1 #

Patch Set 2 : Add README.fuchsia #

Patch Set 3 : Edit README #

Total comments: 6

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1021 lines, -82 lines) Patch
A README.fuchsia View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M dart.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/bin.gypi View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/bin/fuchsia_test.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M runtime/lib/timeline.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M runtime/platform/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/math.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/platform/utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/platform/utils_fuchsia.h View 1 chunk +67 lines, -0 lines 0 comments Download
M runtime/vm/atomic.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + runtime/vm/atomic_fuchsia.h View 1 2 3 2 chunks +20 lines, -15 lines 0 comments Download
M runtime/vm/class_table.h View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/class_table.cc View 7 chunks +8 lines, -1 line 0 comments Download
A runtime/vm/cpuinfo_fuchsia.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M runtime/vm/dev_fs.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/heap.h View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A runtime/vm/native_symbol_fuchsia.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A runtime/vm/os_fuchsia.cc View 1 chunk +223 lines, -0 lines 0 comments Download
M runtime/vm/os_thread.h View 4 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/os_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + runtime/vm/os_thread_fuchsia.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + runtime/vm/os_thread_fuchsia.cc View 7 chunks +19 lines, -38 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/pages.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/pages.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/signal_handler.h View 2 chunks +5 lines, -1 line 0 comments Download
A + runtime/vm/signal_handler_fuchsia.cc View 2 chunks +6 lines, -4 lines 0 comments Download
A runtime/vm/thread_interrupter_fuchsia.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A runtime/vm/virtual_memory_fuchsia.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 3 8 chunks +9 lines, -0 lines 0 comments Download
M tools/build.py View 1 2 3 5 chunks +34 lines, -3 lines 0 comments Download
A tools/fuchsia_link.py View 1 chunk +127 lines, -0 lines 0 comments Download
M tools/gyp/configurations.gypi View 2 chunks +16 lines, -0 lines 0 comments Download
A tools/gyp/configurations_fuchsia.gypi View 1 chunk +152 lines, -0 lines 0 comments Download
M tools/utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zra
4 years, 5 months ago (2016-06-30 22:35:33 UTC) #2
zra
+johnmccutchan for ifndefs in timeline.
4 years, 5 months ago (2016-06-30 22:36:36 UTC) #4
siva
lgtm https://codereview.chromium.org/2117593002/diff/40001/runtime/bin/fuchsia_test.cc File runtime/bin/fuchsia_test.cc (right): https://codereview.chromium.org/2117593002/diff/40001/runtime/bin/fuchsia_test.cc#newcode39 runtime/bin/fuchsia_test.cc:39: } Is this going to morph into the ...
4 years, 5 months ago (2016-07-01 17:09:10 UTC) #5
zra
The extra #ifndef PRODUCTs that aren't needed for other platforms are needed now for Fuchsia ...
4 years, 5 months ago (2016-07-01 18:25:49 UTC) #6
zra
4 years, 5 months ago (2016-07-01 19:42:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
a503570e3a72d6bb21b7c98466ba94faef3f3e5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698