Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2117573002: Storage manager: Update strings and layout. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Update strings and layout. This CL updates strings and layout to match the latest spec. BUG=591958 TEST=manually confirmed CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/710332d7333ff00f427e5c58c5413dde900aed7d Cr-Commit-Position: refs/heads/master@{#403361}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unnecessary line breaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -30 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +23 lines, -8 lines 0 comments Download
A + chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.css View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.css View 4 chunks +38 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fukino
Could you take a look? Thanks! https://codereview.chromium.org/2117573002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2117573002/diff/1/chrome/app/chromeos_strings.grdp#newcode2596 chrome/app/chromeos_strings.grdp:2596: <message name="IDS_OPTIONS_SETTINGS_STORAGE_REMOVE_USER_DIALOG_TITLE" desc="Title ...
4 years, 5 months ago (2016-06-30 18:42:40 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/2117573002/diff/1/chrome/browser/resources/options/chromeos/storage_manager.html File chrome/browser/resources/options/chromeos/storage_manager.html (right): https://codereview.chromium.org/2117573002/diff/1/chrome/browser/resources/options/chromeos/storage_manager.html#newcode34 chrome/browser/resources/options/chromeos/storage_manager.html:34: class="storage-manager-section"> think these will fit in 1 line
4 years, 5 months ago (2016-06-30 22:14:46 UTC) #5
fukino
Thank you! https://codereview.chromium.org/2117573002/diff/1/chrome/browser/resources/options/chromeos/storage_manager.html File chrome/browser/resources/options/chromeos/storage_manager.html (right): https://codereview.chromium.org/2117573002/diff/1/chrome/browser/resources/options/chromeos/storage_manager.html#newcode34 chrome/browser/resources/options/chromeos/storage_manager.html:34: class="storage-manager-section"> On 2016/06/30 22:14:46, Dan Beam wrote: ...
4 years, 5 months ago (2016-06-30 23:19:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117573002/20001
4 years, 5 months ago (2016-06-30 23:21:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 00:14:02 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:18:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/710332d7333ff00f427e5c58c5413dde900aed7d
Cr-Commit-Position: refs/heads/master@{#403361}

Powered by Google App Engine
This is Rietveld 408576698