third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h - Issue 2117543003: [InputEvent] Fill |data| field for 'input' event InsertText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

Issue 2117543003: [InputEvent] Fill |data| field for 'input' event InsertText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add virtual function |textData()| to |EditCommand| Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/EditCommand.h ('K') | « third_party/WebKit/Source/core/editing/commands/EditCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

index b922761634ba937880c70fc21add94f556d91be4..7b4aafc931daeda893a136dfcdf8b00e4432f23b 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

@@ -43,6 +43,8 @@ public:

return new InsertTextCommand(document, text, selectInsertedText, rebalanceType);

}

+ String textData() const override { return m_text; };

yosin_UTC9 2016/07/06 01:20:55 nit: s/override/final/ Please move implementation

chongz 2016/07/06 23:34:32 Done.

private:

InsertTextCommand(Document&, const String& text, bool selectInsertedText, RebalanceType);