[InputEvent] Fill |data| field for 'input' event InsertText

third_party/WebKit/Source/core/editing/Editor.cpp

Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index af360607889dfe0a89484963e17705382a367e14..5c545775a1cef6cebeff559f2aabb9c0b8e1f0e0 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -142,6 +142,13 @@ InputEvent::InputType inputTypeFromCommand(const CompositeEditCommand* command)
     return InputEvent::InputType::None;
 }
 
+String dataFromCommand(const CompositeEditCommand* command)

[yosin_UTC9, 2016/07/06 01:20:55]

It seems having |EditCommand::textDataForInputEvent()| makes our code simpler
and more specific.
Since at this time, we have only one client of |EditCommand::textData()|, which
is dispatching input event.

[chongz, 2016/07/06 23:34:32]

Done.

+{
+    if (!command->isTypingCommand() || toTypingCommand(command)->commandTypeOfOpenCommand() != TypingCommand::InsertText)
+        return emptyString();
+    return command->textData();
+}
+
 InputEvent::EventIsComposing isComposingFromCommand(const CompositeEditCommand* command)
 {
     if (command->isTypingCommand() && toTypingCommand(command)->compositionType() != TypingCommand::TextCompositionNone)
@@ -752,8 +759,7 @@ void Editor::appliedEditing(CompositeEditCommand* cmd)
     DCHECK(composition);
     dispatchEditableContentChangedEvents(composition->startingRootEditableElement(), composition->endingRootEditableElement());
     // TODO(chongz): Filter empty InputType after spec is finalized.
-    // TODO(chongz): Fill in |data| field.
-    dispatchInputEventEditableContentChanged(composition->startingRootEditableElement(), composition->endingRootEditableElement(), inputTypeFromCommand(cmd), emptyString(), isComposingFromCommand(cmd));
+    dispatchInputEventEditableContentChanged(composition->startingRootEditableElement(), composition->endingRootEditableElement(), inputTypeFromCommand(cmd), dataFromCommand(cmd), isComposingFromCommand(cmd));
     VisibleSelection newSelection(cmd->endingSelection());
 
     // Don't clear the typing style with this selection change. We do those things elsewhere if necessary.