third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html - Issue 2117513003: Convert video-source* tests to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html

Issue 2117513003: Convert video-source* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html

diff --git a/third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html b/third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html

index 7ab852c259be9b27456ea6c958414a3c5c25e71b..eb42abf5fb4f6a1130ed4655a1182627f8210d29 100644

--- a/third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html

+++ b/third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html

@@ -1,25 +1,22 @@

-<!doctype html>

-<html>

- <head>

- <title>Add <source> after removing failed candidate</title>

- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

- <script src=video-test.js></script>

- <script src=media-file.js></script>

- <script>

- function error()

- {

- findMediaElement();

- video.removeChild(video.firstChild);

- var source = document.createElement("source");

- source.src = findMediaFile("video", "content/test");

- video.appendChild(source);

- waitForEventAndEnd("loadedmetadata");

- }

- </script>

- </head>

+<!DOCTYPE html>

+<title>Test adding "source" after removing failed candidate loads media normally.</title>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script src="media-file.js"></script>

+<video>

+ <source></source>

+</video>

+<script>

+async_test(function(t) {

+ var video = document.querySelector("video");

+ var source = document.querySelector("source");

- <body>

- <video><source onerror="error()"></video>

- </body>

-</html>

+ source.onerror = t.step_func(function() {

+ video.removeChild(video.firstChild);

+ var newSource = document.createElement("source");

+ newSource.src = findMediaFile("video", "content/test");

+ video.appendChild(newSource);

+ video.onloadedmetadata = t.step_func_done();

+ });

+});

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-source-add-after-remove-expected.txt » ('j') | no next file with comments »