Implement git cl upload -b BUG --bug=BUG.

Implement git cl upload -b BUG --bug=BUG.

CC=friedman@chromium.org
R=sergiyb@chromium.org
BUG=500658
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f9aefb774c206f2daa6e4e363c72a32fef7eda2d

[tandrii(chromium), 2016-06-30 13:46:58]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 13:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-06-30 13:47:30]

PTAL

tested: uploaded this CL with --bug 500658 :)

[commit-bot: I haz the power, 2016-06-30 13:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 13:50:13]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-07-01 14:17:32]

tandrii@chromium.org changed reviewers:
+ andybons@chromium.org

[tandrii(chromium), 2016-07-01 14:17:32]

+andybons@

[Sergiy Byelozyorov, 2016-07-01 14:41:12]

lgtm

https://codereview.chromium.org/2117483002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2117483002/diff/1/git_cl.py#newcode2671
git_cl.py:2671: 'v8:123,chromium:789'
I'd also check if each bug is in '\w+:\d+' format. Otherwise, I can write --bug
'foobar' and it will show up as is. Hm, maybe it's a good thing. I will shoot
myself into the foot and will hopefully become smarter... nvm this comment, read
https://xkcd.com/1700/ instead

https://codereview.chromium.org/2117483002/diff/1/git_cl.py#newcode2681
git_cl.py:2681: return bug
Why is this necessary? You either return inside try or inside exception. Module
quantum bugs, this line should not be reachable.

https://codereview.chromium.org/2117483002/diff/1/git_cl.py#newcode2682
git_cl.py:2682: return ','.join(map(to_str, bugs.split(',')))
How about ', '.join(...)? Looks nicer for humans, but harder to parse later. I
think Rietveld supports this format. Not sure what Gerrit supports.

[tandrii(chromium), 2016-07-01 15:26:57]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 15:27:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-01 15:27:05]

https://codereview.chromium.org/2117483002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2117483002/diff/1/git_cl.py#newcode2671
git_cl.py:2671: 'v8:123,chromium:789'
On 2016/07/01 14:41:12, Sergiy Byelozyorov wrote:
> I'd also check if each bug is in '\w+:\d+' format. Otherwise, I can write
--bug
> 'foobar' and it will show up as is. Hm, maybe it's a good thing. I will shoot
> myself into the foot and will hopefully become smarter... nvm this comment,
read
> https://xkcd.com/1700/ instead

Acknowledged.

https://codereview.chromium.org/2117483002/diff/1/git_cl.py#newcode2681
git_cl.py:2681: return bug
On 2016/07/01 14:41:12, Sergiy Byelozyorov wrote:
> Why is this necessary? You either return inside try or inside exception.
Module
> quantum bugs, this line should not be reachable.

yep, leftover.

https://codereview.chromium.org/2117483002/diff/1/git_cl.py#newcode2682
git_cl.py:2682: return ','.join(map(to_str, bugs.split(',')))
On 2016/07/01 14:41:12, Sergiy Byelozyorov wrote:
> How about ', '.join(...)? Looks nicer for humans, but harder to parse later. I
> think Rietveld supports this format. Not sure what Gerrit supports.

Rietveld doens't care, neither does Gerrit. It's about bugdroid, and after
looking (thanks for making me do so), it actually has this rule:

BUG=proj:1,2 

means proj:1, proj:2. So, I had to cahnge this function to less elegant :(

[commit-bot: I haz the power, 2016-07-01 15:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 15:30:13]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-07-01 15:37:01]

lgtm

https://codereview.chromium.org/2117483002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2117483002/diff/20001/git_cl.py#newcode2694
git_cl.py:2694: # Don't bother finding common prefixes, CLs with >2 bugs are
very very rare.
+1 for writing this comment

[tandrii(chromium), 2016-07-01 16:03:07]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-07-01 16:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 16:06:54]

Description was changed from

==========
Implement git cl upload -b BUG --bug=BUG.

CC=friedman@chromium.org
R=sergiyb@chromium.org
BUG=500658
==========

to

==========
Implement git cl upload -b BUG --bug=BUG.

CC=friedman@chromium.org
R=sergiyb@chromium.org
BUG=500658

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f9aefb774c206f...
==========

[commit-bot: I haz the power, 2016-07-01 16:06:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f9aefb774c206f...