Issue 2117453002: Fix regression for the one case where we deliberately don't follow the RFC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2117453002: Fix regression for the one case where we deliberately don't follow the RFC. (Closed)

Created:
4 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 5 months ago

Reviewers:
eernst

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix regression for the one case where we deliberately don't follow the RFC. The new code didn't have that exception. Also optimize some string operations when it's possible. R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/b39e048c4b74471ad59fa2b62193e4b06055a9df

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -30 lines)			Patch
	M	sdk/lib/core/uri.dart	View	1	2 chunks	+60 lines, -29 lines	0 comments	Download
	M	tests/corelib/uri_test.dart	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

eernst

On 2016/06/30 12:52:02, eernst wrote: > lgtm (Discussed IRL)

4 years, 5 months ago (2016-06-30 12:52:18 UTC) #4

Lasse Reichstein Nielsen

4 years, 5 months ago (2016-06-30 12:52:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b39e048c4b74471ad59fa2b62193e4b06055a9df (presubmit successful).