Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 211743003: Revert of Ignore whitelist when generating android xml. (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
Reviewers:
Jói
CC:
grit-developer_googlegroups.com, johannesa, newt (away), Lambros
Visibility:
Public.

Description

Revert of Ignore whitelist when generating android xml. (https://codereview.chromium.org/196923002/) Reason for revert: This CL breaks the <if expr=""> for Android XML generation. Original issue's description: > Ignore whitelist when generating android xml. > > Whitelist should only apply to the resources used outside of Java. > This helps us to only need to specify the whitelist for C++ resources > without affecting Android XML file generation. > > BUG=338759 > > Patch from issue 196273004, landing for aurimas@chromium.org > > Committed: https://code.google.com/p/grit-i18n/source/detail?r=156 TBR=joi@chromium.org NOTREECHECKS=true NOTRY=true BUG=338759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M grit/format/android_xml.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
aurimas (slooooooooow)
Created Revert of Ignore whitelist when generating android xml.
6 years, 9 months ago (2014-03-25 21:22:00 UTC) #1
aurimas (slooooooooow)
On 2014/03/25 21:22:00, aurimas wrote: > Created Revert of Ignore whitelist when generating android xml. ...
6 years, 9 months ago (2014-03-25 21:49:35 UTC) #2
aurimas (slooooooooow)
6 years, 9 months ago (2014-03-25 21:50:29 UTC) #3
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-03-25 23:33:01 UTC) #4
Sergey Berezin
On 2014/03/25 21:50:29, aurimas wrote: There is no CQ for this repo, unchecking the commit ...
6 years, 9 months ago (2014-03-25 23:33:33 UTC) #5
Jói
LGTM, will land. Note that since the change being reverted is the latest revision of ...
6 years, 9 months ago (2014-03-26 09:53:39 UTC) #6
Jói
6 years, 9 months ago (2014-03-26 09:58:02 UTC) #7
On 2014/03/26 09:53:39, Jói wrote:
> LGTM, will land.
> 
> Note that since the change being reverted is the latest revision of GRIT, a
> temporary quick fix (e.g., if it had been an emergency right before the M35
> branch) would have been to roll DEPS back to the previous version.

Landed as r157 via https://codereview.chromium.org/212563002/

Powered by Google App Engine
This is Rietveld 408576698