Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2117413002: Reland: Re-enable DexLoaderTests (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Re-enable DexLoaderTests https://codereview.chromium.org/2045313002/ fixed the bug with dx --incremental causing the DexLoaderTests to fail on partial rebuilds of chrome_public_test_apk BUG=617935 Committed: https://crrev.com/14dae967f38c1314ac7b2e3b0cc061f4b39da6ff Cr-Commit-Position: refs/heads/master@{#403808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pkotwicz
Xi can you please take a look? I am hoping that if anything goes wrong ...
4 years, 5 months ago (2016-07-05 15:29:47 UTC) #2
Xi Han
lgtm
4 years, 5 months ago (2016-07-05 18:05:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117413002/1
4 years, 5 months ago (2016-07-05 18:06:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 18:36:33 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 18:36:34 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 18:38:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14dae967f38c1314ac7b2e3b0cc061f4b39da6ff
Cr-Commit-Position: refs/heads/master@{#403808}

Powered by Google App Engine
This is Rietveld 408576698