Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2117403002: [compiler] Fix AccessBuilder::ForNameHashField (Closed)

Created:
4 years, 5 months ago by john.yan
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Fix AccessBuilder::ForNameHashField HashField is a 32-bit field. R=bmeurer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/a43764e13e1812a68eaf4140f3ce5f3052a0d551 Cr-Commit-Position: refs/heads/master@{#37557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/access-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 5 months ago (2016-07-05 15:05:46 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-06 10:25:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117403002/1
4 years, 5 months ago (2016-07-06 14:27:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 15:08:07 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 15:10:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a43764e13e1812a68eaf4140f3ce5f3052a0d551
Cr-Commit-Position: refs/heads/master@{#37557}

Powered by Google App Engine
This is Rietveld 408576698