Cleanup array constructor inlining in crankshaft

Cleanup array constructor inlining in crankshaft

This CL removes unnecessary complexity from crankshaft, possible due to the
move of ArrayConstructor to code-stub-assembler. Making the code easier
hopefully helps us find bugs.

BUG=

Committed: https://crrev.com/71eabf5c8071c914364d7f268073633f20c3c3ab
Cr-Commit-Position: refs/heads/master@{#37536}

[Toon Verwaest, 2016-07-05 13:51:51]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2016-07-05 13:51:51]

ptal

[Jakob Kummerow, 2016-07-05 15:18:06]

Nice cleanup! LGTM with nits.

https://codereview.chromium.org/2117383002/diff/20001/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (left):

https://codereview.chromium.org/2117383002/diff/20001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.cc:10182: TraceInline(target, caller, NULL);
Where'd this go?

https://codereview.chromium.org/2117383002/diff/20001/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/2117383002/diff/20001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.cc:9950: // Allocate (dealing with failure
appropriately)
nit: trailing full stop (4 more times below).

[Toon Verwaest, 2016-07-05 15:21:52]

Addressed comments

[Toon Verwaest, 2016-07-05 15:45:25]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-07-05 15:45:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2117383002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-07-05 15:45:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 16:13:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-05 16:16:39]

Description was changed from

==========
Cleanup array constructor inlining in crankshaft

This CL removes unnecessary complexity from crankshaft, possible due to the
move of ArrayConstructor to code-stub-assembler. Making the code easier
hopefully helps us find bugs.

BUG=
==========

to

==========
Cleanup array constructor inlining in crankshaft

This CL removes unnecessary complexity from crankshaft, possible due to the
move of ArrayConstructor to code-stub-assembler. Making the code easier
hopefully helps us find bugs.

BUG=

Committed: https://crrev.com/71eabf5c8071c914364d7f268073633f20c3c3ab
Cr-Commit-Position: refs/heads/master@{#37536}
==========

[commit-bot: I haz the power, 2016-07-05 16:16:40]

Patchset 3 (id:??) landed as
https://crrev.com/71eabf5c8071c914364d7f268073633f20c3c3ab
Cr-Commit-Position: refs/heads/master@{#37536}