tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 020b6873f0b422f8e2fe43420c3d340a5d9b8c09..f7906a90ac5cf8e459c1755819f7b14be991ae4b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -99412,8 +99412,24 @@ To add a new entry, add it with any value and run test to compute valid value.
   <suffix name="8" label="8th startup with same version"/>
   <suffix name="9" label="9th startup with same version"/>
   <suffix name="Over" label="&gt; 9th startup with same version"/>
+  <affected-histogram name="Startup.BrowserMainToRendererMain"/>
   <affected-histogram name="Startup.BrowserMessageLoopStartHardFaultCount"/>
+  <affected-histogram name="Startup.BrowserMessageLoopStartTime"/>
+  <affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry"/>
+  <affected-histogram
+      name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun"/>

[gab, 2016/07/07 15:41:56]

It's overkill for the first run histogram.

Cold/warm probably also is FWIW (we could look at stats but I'd be very
surprised to see many warm first runs; it's possible with --first-run but very
unlikely in the wild). So maybe not suffixing that one is the right thing to do.

[fdoray, 2016/07/08 14:52:52]

Done.

+  <affected-histogram name="Startup.BrowserOpenTabs"/>
+  <affected-histogram name="Startup.BrowserWindowDisplay"/>

[gab, 2016/07/07 15:41:56]

Also note that BrowserWindowDisplay is itself broken in its own ways:
http://crbug.com/589118

[gab, 2016/07/07 15:41:56]

 - RecordBrowserWindowDisplay()
 - RecordBrowserOpenTabsDelta()

are called too early for warm/cold today and may also be for this:
http://crbug.com/580207

We don't have to fix this in this CL but those suffixes are likely broken until
we do.

I think what we should do is have a method which histogram logging is delegated
to and which knows to queue them until all suffixes have been registered so that
the early ones all get properly suffixed.

[fdoray, 2016/07/08 14:52:52]

ok, I keep these histograms here and we'll fix them in separate CLs?

[gab, 2016/07/08 19:56:19]

sgtm

+  <affected-histogram name="Startup.FirstWebContents.MainFrameLoad2"/>
+  <affected-histogram name="Startup.FirstWebContents.MainNavigationFinished"/>
+  <affected-histogram name="Startup.FirstWebContents.MainNavigationStart"/>
+  <affected-histogram name="Startup.FirstWebContents.NonEmptyPaint2"/>
+  <affected-histogram name="Startup.LoadTime.ExeMainToDllMain"/>
+  <affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain"/>
+  <affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain"/>
+  <affected-histogram name="Startup.SystemUptime"/>
   <affected-histogram name="Startup.Temperature"/>
+  <affected-histogram name="Startup.TimeSinceLastStartup"/>
 </histogram_suffixes>
 
 <histogram_suffixes name="SB2ResourceTypes" separator=".">