Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10041)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index ae07c78cc626133819398c6fa4b7d83f13276449..5e6374576145ec15833e6bac4a07c2d41c3bac57 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -269,15 +269,15 @@ void SearchBox::LogEvent(NTPLoggingEventType event) {
}
void SearchBox::LogMostVisitedImpression(int position,
- const base::string16& provider) {
+ NTPLoggingTileSource tile_source) {
render_view()->Send(new ChromeViewHostMsg_LogMostVisitedImpression(
- render_view()->GetRoutingID(), page_seq_no_, position, provider));
+ render_view()->GetRoutingID(), page_seq_no_, position, tile_source));
}
void SearchBox::LogMostVisitedNavigation(int position,
- const base::string16& provider) {
+ NTPLoggingTileSource tile_source) {
render_view()->Send(new ChromeViewHostMsg_LogMostVisitedNavigation(
- render_view()->GetRoutingID(), page_seq_no_, position, provider));
+ render_view()->GetRoutingID(), page_seq_no_, position, tile_source));
}
void SearchBox::CheckIsUserSignedInToChromeAs(const base::string16& identity) {
« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698