Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4269)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 143ebb1d32546ff04c6f2e61f7b14020a77f1905..acb2a86f90dd76e92359b0848145160ce4c2ada6 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -477,20 +477,20 @@ void SearchTabHelper::OnLogEvent(NTPLoggingEventType event,
}
void SearchTabHelper::OnLogMostVisitedImpression(
- int position, const base::string16& provider) {
+ int position, NTPLoggingTileSource tile_source) {
// TODO(kmadhusu): Move platform specific code from here and get rid of #ifdef.
#if !defined(OS_ANDROID)
NTPUserDataLogger::GetOrCreateFromWebContents(
- web_contents())->LogMostVisitedImpression(position, provider);
+ web_contents())->LogMostVisitedImpression(position, tile_source);
#endif
}
void SearchTabHelper::OnLogMostVisitedNavigation(
- int position, const base::string16& provider) {
+ int position, NTPLoggingTileSource tile_source) {
// TODO(kmadhusu): Move platform specific code from here and get rid of #ifdef.
#if !defined(OS_ANDROID)
NTPUserDataLogger::GetOrCreateFromWebContents(
- web_contents())->LogMostVisitedNavigation(position, provider);
+ web_contents())->LogMostVisitedNavigation(position, tile_source);
#endif
}
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.h ('k') | chrome/browser/ui/search/search_tab_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698