Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3377)

Unified Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_ipc_router.h
diff --git a/chrome/browser/ui/search/search_ipc_router.h b/chrome/browser/ui/search/search_ipc_router.h
index 79a375ed1c1f6a9260222bdbddca9428ed1ab5e5..462ac458a5c8e43b36c7c7b5e41758887d25b929 100644
--- a/chrome/browser/ui/search/search_ipc_router.h
+++ b/chrome/browser/ui/search/search_ipc_router.h
@@ -56,12 +56,14 @@ class SearchIPCRouter : public content::WebContentsObserver {
base::TimeDelta time) = 0;
// Called to log an impression from a given provider on the New Tab Page.
- virtual void OnLogMostVisitedImpression(int position,
- const base::string16& provider) = 0;
+ virtual void OnLogMostVisitedImpression(
+ int position,
+ NTPLoggingTileSource tile_source) = 0;
// Called to log a navigation from a given provider on the New Tab Page.
- virtual void OnLogMostVisitedNavigation(int position,
- const base::string16& provider) = 0;
+ virtual void OnLogMostVisitedNavigation(
+ int position,
+ NTPLoggingTileSource tile_source) = 0;
// Called when the page wants to paste the |text| (or the clipboard contents
// if the |text| is empty) into the omnibox.
@@ -188,10 +190,10 @@ class SearchIPCRouter : public content::WebContentsObserver {
base::TimeDelta time) const;
void OnLogMostVisitedImpression(int page_seq_no,
int position,
- const base::string16& provider) const;
+ NTPLoggingTileSource tile_source) const;
void OnLogMostVisitedNavigation(int page_seq_no,
int position,
- const base::string16& provider) const;
+ NTPLoggingTileSource tile_source) const;
void OnPasteAndOpenDropDown(int page_seq_no,
const base::string16& text) const;
void OnChromeIdentityCheck(int page_seq_no,
« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_util.js ('k') | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698