chrome/browser/ui/webui/ntp/ntp_user_data_logger.h - Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup

Patch Set: TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | chrome/common/ntp_logging_events.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

index f17ada84dadb535cc5aa1b2ed3b2615c8ec50d84..d2a5446a4d48fe252d9fdefebb821c073d144eea 100644

--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

@@ -41,11 +41,11 @@ class NTPUserDataLogger

// this event happened.

void LogEvent(NTPLoggingEventType event, base::TimeDelta time);

- // Logs an impression on one of the Most Visited tiles by a given provider.

- void LogMostVisitedImpression(int position, const base::string16& provider);

+ // Logs an impression on one of the NTP tiles by a given source.

+ void LogMostVisitedImpression(int position, NTPLoggingTileSource tile_source);

- // Logs a navigation on one of the Most Visited tiles by a given provider.

- void LogMostVisitedNavigation(int position, const base::string16& provider);

+ // Logs a navigation on one of the NTP tiles by a given source.

+ void LogMostVisitedNavigation(int position, NTPLoggingTileSource tile_source);

// content::WebContentsObserver override

void NavigationEntryCommitted(