chrome/browser/ui/search/search_tab_helper.h - Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup

Patch Set: TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | chrome/common/ntp_logging_events.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.h

diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h

index 22aa0eb0edd802478666f2409a351c78f9eef52a..c0cf88e17273c5fa3ef378566237f62f577be759 100644

--- a/chrome/browser/ui/search/search_tab_helper.h

+++ b/chrome/browser/ui/search/search_tab_helper.h

@@ -165,9 +165,9 @@ class SearchTabHelper : public content::WebContentsObserver,

void OnUndoAllMostVisitedDeletions() override;

void OnLogEvent(NTPLoggingEventType event, base::TimeDelta time) override;

void OnLogMostVisitedImpression(int position,

- const base::string16& provider) override;

+ NTPLoggingTileSource tile_source) override;

void OnLogMostVisitedNavigation(int position,

- const base::string16& provider) override;

+ NTPLoggingTileSource tile_source) override;

void PasteIntoOmnibox(const base::string16& text) override;

void OnChromeIdentityCheck(const base::string16& identity) override;

void OnHistorySyncCheck() override;