chrome/common/ntp_logging_events.h - Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/ntp_logging_events.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/local_ntp/most_visited_util.js ('K') | « chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/ntp_logging_events.h

diff --git a/chrome/common/ntp_logging_events.h b/chrome/common/ntp_logging_events.h

index be1bfeef6358ab75c2b94edd9b4cbed86ddf11fe..cec183415a84dfa6664a7606dd5abdbf59107d05 100644

--- a/chrome/common/ntp_logging_events.h

+++ b/chrome/common/ntp_logging_events.h

@@ -49,4 +49,14 @@ enum NTPLoggingEventType {

NTP_EVENT_TYPE_LAST = NTP_TILE_LOADED

};

+// The source of an NTP tile.

+// Note: Keep in sync with browser/resources/local_ntp/most_visited_util.js and

+// browser/resources/local_ntp/most_visited_single.js.

+// TODO(treib): Merge this into MostVisitedSource from components/ntp_tiles.

+enum NTPLoggingTileSource {

+ NTP_TILE_SOURCE_CLIENT = 0,

+ NTP_TILE_SOURCE_SERVER = 1,

+ NTP_TILE_SOURCE_LAST = NTP_TILE_SOURCE_SERVER

+};

#endif // CHROME_COMMON_NTP_LOGGING_EVENTS_H_