Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
6 #define CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_ 6 #define CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 const content::LoadCommittedDetails& load_details) override; 158 const content::LoadCommittedDetails& load_details) override;
159 159
160 // Overridden from SearchIPCRouter::Delegate: 160 // Overridden from SearchIPCRouter::Delegate:
161 void OnInstantSupportDetermined(bool supports_instant) override; 161 void OnInstantSupportDetermined(bool supports_instant) override;
162 void FocusOmnibox(OmniboxFocusState state) override; 162 void FocusOmnibox(OmniboxFocusState state) override;
163 void OnDeleteMostVisitedItem(const GURL& url) override; 163 void OnDeleteMostVisitedItem(const GURL& url) override;
164 void OnUndoMostVisitedDeletion(const GURL& url) override; 164 void OnUndoMostVisitedDeletion(const GURL& url) override;
165 void OnUndoAllMostVisitedDeletions() override; 165 void OnUndoAllMostVisitedDeletions() override;
166 void OnLogEvent(NTPLoggingEventType event, base::TimeDelta time) override; 166 void OnLogEvent(NTPLoggingEventType event, base::TimeDelta time) override;
167 void OnLogMostVisitedImpression(int position, 167 void OnLogMostVisitedImpression(int position,
168 const base::string16& provider) override; 168 NTPLoggingTileSource tile_source) override;
169 void OnLogMostVisitedNavigation(int position, 169 void OnLogMostVisitedNavigation(int position,
170 const base::string16& provider) override; 170 NTPLoggingTileSource tile_source) override;
171 void PasteIntoOmnibox(const base::string16& text) override; 171 void PasteIntoOmnibox(const base::string16& text) override;
172 void OnChromeIdentityCheck(const base::string16& identity) override; 172 void OnChromeIdentityCheck(const base::string16& identity) override;
173 void OnHistorySyncCheck() override; 173 void OnHistorySyncCheck() override;
174 174
175 // Overridden from InstantServiceObserver: 175 // Overridden from InstantServiceObserver:
176 void ThemeInfoChanged(const ThemeBackgroundInfo& theme_info) override; 176 void ThemeInfoChanged(const ThemeBackgroundInfo& theme_info) override;
177 void MostVisitedItemsChanged( 177 void MostVisitedItemsChanged(
178 const std::vector<InstantMostVisitedItem>& items) override; 178 const std::vector<InstantMostVisitedItem>& items) override;
179 179
180 // Sets the mode of the model based on the current URL of web_contents(). 180 // Sets the mode of the model based on the current URL of web_contents().
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 SearchTabHelperDelegate* delegate_; 228 SearchTabHelperDelegate* delegate_;
229 229
230 // Function to check if the omnibox has focus. Tests use this to modify the 230 // Function to check if the omnibox has focus. Tests use this to modify the
231 // default behavior. 231 // default behavior.
232 OmniboxHasFocusFn omnibox_has_focus_fn_; 232 OmniboxHasFocusFn omnibox_has_focus_fn_;
233 233
234 DISALLOW_COPY_AND_ASSIGN(SearchTabHelper); 234 DISALLOW_COPY_AND_ASSIGN(SearchTabHelper);
235 }; 235 };
236 236
237 #endif // CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_ 237 #endif // CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698