Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/ntp_logging_events.h » ('j') | chrome/common/ntp_logging_events.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h" 5 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "base/metrics/statistics_recorder.h" 8 #include "base/metrics/statistics_recorder.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/common/ntp_logging_events.h" 10 #include "chrome/common/ntp_logging_events.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTileFallbacks")); 101 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTileFallbacks"));
102 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTileFallbacks")); 102 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTileFallbacks"));
103 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTiles")); 103 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTiles"));
104 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTiles")); 104 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTiles"));
105 EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsType")); 105 EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsType"));
106 } 106 }
107 107
108 TEST_F(NTPUserDataLoggerTest, TestLogMostVisitedImpression) { 108 TEST_F(NTPUserDataLoggerTest, TestLogMostVisitedImpression) {
109 base::StatisticsRecorder::Initialize(); 109 base::StatisticsRecorder::Initialize();
110 110
111 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 1)); 111 EXPECT_EQ(0, GetTotalCount("NewTabPage.SuggestionsImpression"));
112 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 5)); 112 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.server", 1));
113 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.server", 5));
114 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 1));
115 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 5));
113 116
114 TestNTPUserDataLogger logger; 117 TestNTPUserDataLogger logger;
115 118
116 logger.LogMostVisitedImpression(1, base::ASCIIToUTF16("foobar")); 119 logger.LogMostVisitedImpression(1, NTP_TILE_SOURCE_SERVER);
117 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 1)); 120 EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsImpression"));
118 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 5)); 121 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 1));
122 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.server", 5));
123 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 1));
124 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 5));
119 125
120 logger.LogMostVisitedImpression(5, base::ASCIIToUTF16("foobar")); 126 logger.LogMostVisitedImpression(5, NTP_TILE_SOURCE_SERVER);
121 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 1)); 127 EXPECT_EQ(2, GetTotalCount("NewTabPage.SuggestionsImpression"));
122 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 5)); 128 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 1));
129 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 5));
130 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 1));
131 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 5));
123 132
124 // Try without provider. Only total increases. 133 logger.LogMostVisitedImpression(1, NTP_TILE_SOURCE_CLIENT);
125 logger.LogMostVisitedImpression(5, base::ASCIIToUTF16("")); 134 EXPECT_EQ(3, GetTotalCount("NewTabPage.SuggestionsImpression"));
126 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 1)); 135 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 1));
127 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 5)); 136 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 5));
137 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.client", 1));
138 EXPECT_EQ(0, GetBinCount("NewTabPage.SuggestionsImpression.client", 5));
128 139
129 logger.LogMostVisitedImpression(1, base::ASCIIToUTF16("foobar")); 140 logger.LogMostVisitedImpression(5, NTP_TILE_SOURCE_CLIENT);
130 EXPECT_EQ(2, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 1)); 141 EXPECT_EQ(4, GetTotalCount("NewTabPage.SuggestionsImpression"));
131 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.foobar", 5)); 142 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 1));
143 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.server", 5));
144 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.client", 1));
145 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsImpression.client", 5));
132 } 146 }
133 147
134 TEST_F(NTPUserDataLoggerTest, TestLogMostVisitedNavigation) { 148 TEST_F(NTPUserDataLoggerTest, TestLogMostVisitedNavigation) {
135 base::StatisticsRecorder::Initialize(); 149 base::StatisticsRecorder::Initialize();
136 150
137 EXPECT_EQ(0, GetTotalCount("NewTabPage.MostVisited")); 151 EXPECT_EQ(0, GetTotalCount("NewTabPage.MostVisited"));
138 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 152 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.server", 1));
139 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 153 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.server", 5));
154 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 1));
155 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 5));
140 156
141 TestNTPUserDataLogger logger; 157 TestNTPUserDataLogger logger;
142 158
143 logger.LogMostVisitedNavigation(1, base::ASCIIToUTF16("foobar")); 159 logger.LogMostVisitedNavigation(1, NTP_TILE_SOURCE_SERVER);
144 EXPECT_EQ(1, GetTotalCount("NewTabPage.MostVisited")); 160 EXPECT_EQ(1, GetTotalCount("NewTabPage.MostVisited"));
145 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 161 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 1));
146 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 162 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.server", 5));
163 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 1));
164 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 5));
147 165
148 logger.LogMostVisitedNavigation(5, base::ASCIIToUTF16("foobar")); 166 logger.LogMostVisitedNavigation(5, NTP_TILE_SOURCE_SERVER);
149 EXPECT_EQ(2, GetTotalCount("NewTabPage.MostVisited")); 167 EXPECT_EQ(2, GetTotalCount("NewTabPage.MostVisited"));
150 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 168 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 1));
151 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 169 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 5));
170 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 1));
171 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 5));
152 172
153 // Try without provider. Only total increases. 173 logger.LogMostVisitedNavigation(1, NTP_TILE_SOURCE_CLIENT);
154 logger.LogMostVisitedNavigation(5, base::ASCIIToUTF16(""));
155 EXPECT_EQ(3, GetTotalCount("NewTabPage.MostVisited")); 174 EXPECT_EQ(3, GetTotalCount("NewTabPage.MostVisited"));
156 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 175 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 1));
157 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 176 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 5));
177 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.client", 1));
178 EXPECT_EQ(0, GetBinCount("NewTabPage.MostVisited.client", 5));
158 179
159 logger.LogMostVisitedNavigation(1, base::ASCIIToUTF16("foobar")); 180 logger.LogMostVisitedNavigation(5, NTP_TILE_SOURCE_CLIENT);
160 EXPECT_EQ(4, GetTotalCount("NewTabPage.MostVisited")); 181 EXPECT_EQ(4, GetTotalCount("NewTabPage.MostVisited"));
161 EXPECT_EQ(2, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 182 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 1));
162 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 183 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.server", 5));
184 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.client", 1));
185 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.client", 5));
163 } 186 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/ntp_logging_events.h » ('j') | chrome/common/ntp_logging_events.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698