Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

chrome/browser/ui/search/search_ipc_router.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_
 #define CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 38 matching lines @@
 
     // Called when the SearchBox wants to undo all Most Visited deletions.
     virtual void OnUndoAllMostVisitedDeletions() = 0;
 
     // Called to signal that an event has occurred on the New Tab Page at a
     // particular time since navigation start.
     virtual void OnLogEvent(NTPLoggingEventType event,
                             base::TimeDelta time) = 0;
 
     // Called to log an impression from a given provider on the New Tab Page.
-    virtual void OnLogMostVisitedImpression(int position,
-                                            const base::string16& provider) = 0;
+    virtual void OnLogMostVisitedImpression(
+        int position,
+        NTPLoggingTileSource tile_source) = 0;
 
     // Called to log a navigation from a given provider on the New Tab Page.
-    virtual void OnLogMostVisitedNavigation(int position,
-                                            const base::string16& provider) = 0;
+    virtual void OnLogMostVisitedNavigation(
+        int position,
+        NTPLoggingTileSource tile_source) = 0;
 
     // Called when the page wants to paste the |text| (or the clipboard contents
     // if the |text| is empty) into the omnibox.
     virtual void PasteIntoOmnibox(const base::string16& text) = 0;
 
     // Called when the SearchBox wants to verify the signed-in Chrome identity
     // against the provided |identity|. Will make a round-trip to the browser
     // and eventually return the result through SendChromeIdentityCheckResult.
     // Calls SendChromeIdentityCheckResult with true if the identity matches.
     virtual void OnChromeIdentityCheck(const base::string16& identity) = 0;
@@ skipping 106 matching lines @@
   void OnInstantSupportDetermined(int page_seq_no, bool supports_instant) const;
   void OnFocusOmnibox(int page_id, OmniboxFocusState state) const;
   void OnDeleteMostVisitedItem(int page_seq_no, const GURL& url) const;
   void OnUndoMostVisitedDeletion(int page_seq_no, const GURL& url) const;
   void OnUndoAllMostVisitedDeletions(int page_seq_no) const;
   void OnLogEvent(int page_seq_no,
                   NTPLoggingEventType event,
                   base::TimeDelta time) const;
   void OnLogMostVisitedImpression(int page_seq_no,
                                   int position,
-                                  const base::string16& provider) const;
+                                  NTPLoggingTileSource tile_source) const;
   void OnLogMostVisitedNavigation(int page_seq_no,
                                   int position,
-                                  const base::string16& provider) const;
+                                  NTPLoggingTileSource tile_source) const;
   void OnPasteAndOpenDropDown(int page_seq_no,
                               const base::string16& text) const;
   void OnChromeIdentityCheck(int page_seq_no,
                              const base::string16& identity) const;
   void OnHistorySyncCheck(int page_seq_no) const;
 
   // Used by unit tests to set a fake delegate.
   void set_delegate_for_testing(Delegate* delegate);
 
   // Used by unit tests.
@@ skipping 12 matching lines @@
   // SearchIPCRouter to ensure that delayed IPC replies are ignored.
   int commit_counter_;
 
   // Set to true, when the tab corresponding to |this| instance is active.
   bool is_active_tab_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchIPCRouter);
 };
 
 #endif  // CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_