Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117363002:
analyze: ignore changes to OWNERS files (Closed)
|
Created:
4 years, 5 months ago by Paweł Hajdan Jr. Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionanalyze: ignore changes to OWNERS files
BUG=595176
Committed: https://crrev.com/f63a13b37a2ed66080bc4b91cff9cc1fa3678cb5
Cr-Commit-Position: refs/heads/master@{#403797}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix #
Total comments: 1
Messages
Total messages: 15 (4 generated)
phajdan.jr@chromium.org changed reviewers: + emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org
See the bug and https://codereview.chromium.org/1929553002 for context.
https://codereview.chromium.org/2117363002/diff/1/testing/buildbot/trybot_ana... File testing/buildbot/trybot_analyze_config.json (right): https://codereview.chromium.org/2117363002/diff/1/testing/buildbot/trybot_ana... testing/buildbot/trybot_analyze_config.json:32: ".*OWNERS" i think two entries like this is better: ".*/OWNERS", "OWNERS" otherwise you may ignore non-OWNERS files like balbla/WTFOWNERS
https://codereview.chromium.org/2117363002/diff/1/testing/buildbot/trybot_ana... File testing/buildbot/trybot_analyze_config.json (right): https://codereview.chromium.org/2117363002/diff/1/testing/buildbot/trybot_ana... testing/buildbot/trybot_analyze_config.json:32: ".*OWNERS" On 2016/07/05 at 13:38:44, tandrii(chromium) wrote: > i think two entries like this is better: > ".*/OWNERS", "OWNERS" > otherwise you may ignore non-OWNERS files like balbla/WTFOWNERS Good point. Done.
lgtm
lgtm https://codereview.chromium.org/2117363002/diff/20001/testing/buildbot/trybot... File testing/buildbot/trybot_analyze_config.json (right): https://codereview.chromium.org/2117363002/diff/20001/testing/buildbot/trybot... testing/buildbot/trybot_analyze_config.json:31: "ignores": [ I'm surprized that we didn't have any files that we ignored before this, e.g. whitespace.
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== analyze: ignore changes to OWNERS files BUG=595176 ========== to ========== analyze: ignore changes to OWNERS files BUG=595176 Committed: https://crrev.com/f63a13b37a2ed66080bc4b91cff9cc1fa3678cb5 Cr-Commit-Position: refs/heads/master@{#403797} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f63a13b37a2ed66080bc4b91cff9cc1fa3678cb5 Cr-Commit-Position: refs/heads/master@{#403797}
Message was sent while issue was closed.
jam@chromium.org changed reviewers: + dpranke@chromium.org, jam@chromium.org
Message was sent while issue was closed.
I don't think we should do this, this is a bandaid. The bug, which is a regression from gyp->gn, is https://bugs.chromium.org/p/chromium/issues/detail?id=555273
Message was sent while issue was closed.
On 2016/07/18 21:47:29, jam wrote: > I don't think we should do this, this is a bandaid. > > The bug, which is a regression from gyp->gn, is > https://bugs.chromium.org/p/chromium/issues/detail?id=555273 This is just confusing ... I don't know why a change to an OWNERS file would cause a compile for either GYP or GN builds. Can we produce a link to where this is happening so I can look at it? crbug.com/555273 is (I believe, at least) a different issue.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2155323002/ by dpranke@chromium.org. The reason for reverting is: reverting this since I don't think it should've been needed and I'd like to look at the problem further. I will re-land or fix as appropriate if I can reproduce the underlying bug.. |
