Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler.
The client will be creating an instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
Committed: https://crrev.com/120b753f71af7588480f4e35bdb6ffb001e87e2e
Cr-Commit-Position: refs/heads/master@{#37613}

[alph, 2016-07-06 19:28:18]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 19:28:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-07-06 19:29:37]

Description was changed from

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

to

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler. The client will be creating an
instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

[commit-bot: I haz the power, 2016-07-06 19:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 19:55:01]

Dry run: This issue passed the CQ dry run.

[alph, 2016-07-06 20:32:58]

alph@chromium.org changed reviewers:
+ jochen@chromium.org, lpy@chromium.org, yangguo@chromium.org

[lpy, 2016-07-06 21:34:35]

Could you please make the description fit to 80-column?

https://codereview.chromium.org/2117343006/diff/1/test/cctest/test-cpu-profil...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/2117343006/diff/1/test/cctest/test-cpu-profil...
test/cctest/test-cpu-profiler.cc:1010: v8::internal::ProfilerExtension::Scope
profiler_scope(CcTest::isolate());
I don't understand why we use a scope here to create and dispose profiler. Can
we use ProfilerHelper only?

[alph, 2016-07-06 21:45:16]

https://codereview.chromium.org/2117343006/diff/1/test/cctest/test-cpu-profil...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/2117343006/diff/1/test/cctest/test-cpu-profil...
test/cctest/test-cpu-profiler.cc:1010: v8::internal::ProfilerExtension::Scope
profiler_scope(CcTest::isolate());
On 2016/07/06 21:34:35, lpy wrote:
> I don't understand why we use a scope here to create and dispose profiler. Can
> we use ProfilerHelper only?

Besides ProfilerHelper ProfilerExtension does also need profiler. So one of them
has to own the profiler. I made it to be the Scope.

[alph, 2016-07-06 21:45:49]

Description was changed from

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler. The client will be creating an
instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

to

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler.
The client will be creating an instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

[lpy, 2016-07-06 21:59:48]

Thanks for the clarification.
LGTM from my side.

[alph, 2016-07-06 22:42:32]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 22:42:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:09:16]

Dry run: This issue passed the CQ dry run.

[alph, 2016-07-06 23:12:41]

Yang, could you please take a look.

https://codereview.chromium.org/2117343006/diff/1/test/cctest/test-cpu-profil...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/2117343006/diff/1/test/cctest/test-cpu-profil...
test/cctest/test-cpu-profiler.cc:1010: v8::internal::ProfilerExtension::Scope
profiler_scope(CcTest::isolate());
On 2016/07/06 21:45:16, alph wrote:
> On 2016/07/06 21:34:35, lpy wrote:
> > I don't understand why we use a scope here to create and dispose profiler.
Can
> > we use ProfilerHelper only?
> 
> Besides ProfilerHelper ProfilerExtension does also need profiler. So one of
them
> has to own the profiler. I made it to be the Scope.

I simplified it a bit.

[Yang, 2016-07-08 09:43:48]

lgtm

[alph, 2016-07-08 14:33:07]

The CQ bit was checked by alph@chromium.org

[alph, 2016-07-08 14:33:08]

The patchset sent to the CQ was uploaded after l-g-t-m from lpy@chromium.org
Link to the patchset: https://codereview.chromium.org/2117343006/#ps20001
(title: "Remove ProfilerExtension::Scope")

[commit-bot: I haz the power, 2016-07-08 14:33:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 15:00:32]

Description was changed from

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler.
The client will be creating an instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

to

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler.
The client will be creating an instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

[commit-bot: I haz the power, 2016-07-08 15:00:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 15:01:22]

Description was changed from

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler.
The client will be creating an instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789
==========

to

==========
Introduce v8::CpuProfiler::New and v8::CpuProfiler::Dispose API.

Isolate is not going to retain a CPU profiler.
The client will be creating an instance of profiler when needed.

Deprectate v8::Isolate::GetCpuProfiler()

BUG=v8:4789

Committed: https://crrev.com/120b753f71af7588480f4e35bdb6ffb001e87e2e
Cr-Commit-Position: refs/heads/master@{#37613}
==========

[commit-bot: I haz the power, 2016-07-08 15:01:23]

Patchset 2 (id:??) landed as
https://crrev.com/120b753f71af7588480f4e35bdb6ffb001e87e2e
Cr-Commit-Position: refs/heads/master@{#37613}