rebaseline_server: delete invalid image files from local disk cache

rebaseline_server: delete invalid image files from local disk cache

BUG=skia:2247
NOTREECHECKS=True
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13951

[epoger, 2014-03-25 22:04:53]

Ready for review at patchset 1... seems to work as expected in local testing.

[borenet, 2014-03-26 13:17:20]

LGTM with question

https://codereview.chromium.org/211733004/diff/1/gm/rebaseline_server/imagedi...
File gm/rebaseline_server/imagediffdb.py (right):

https://codereview.chromium.org/211733004/diff/1/gm/rebaseline_server/imagedi...
gm/rebaseline_server/imagediffdb.py:393: os.remove(filepath)
Is there a chance that the file may not exist?  I guess we don't care too much
if os.remove raises an exception, since we're about to raise IOError anyway.

[epoger, 2014-03-26 13:38:11]

https://codereview.chromium.org/211733004/diff/1/gm/rebaseline_server/imagedi...
File gm/rebaseline_server/imagediffdb.py (right):

https://codereview.chromium.org/211733004/diff/1/gm/rebaseline_server/imagedi...
gm/rebaseline_server/imagediffdb.py:393: os.remove(filepath)
On 2014/03/26 13:17:21, borenet wrote:
> Is there a chance that the file may not exist?  I guess we don't care too much
> if os.remove raises an exception, since we're about to raise IOError anyway.

I suppose it's possible.  For the reason you mention, I figured I would just
keep the change as simple as possible.

[epoger, 2014-03-26 13:38:16]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-26 13:38:22]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/211733004/1

[commit-bot: I haz the power, 2014-03-26 13:38:31]

Change committed as 13951