third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2117313002: Remove WebURLResponse::initialize() [revised]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2117313002: Remove WebURLResponse::initialize() [revised] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanups Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebURLResponseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 2c5d98d32584aa66a7ff4c3a5b0c538cd0740bfe..55a9b82e9c94bbeac100768d8468491e133235d2 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -208,7 +208,6 @@ protected:

void registerMockedHttpURLLoadWithCSP(const std::string& fileName, const std::string& csp, bool reportOnly = false)

{

WebURLResponse response;

- response.initialize();

response.setMIMEType("text/html");

response.addHTTPHeaderField(reportOnly ? WebString("Content-Security-Policy-Report-Only") : WebString("Content-Security-Policy"), WebString::fromUTF8(csp));

std::string fullString = m_baseURL + fileName;

@@ -5074,7 +5073,6 @@ TEST_P(ParameterizedWebFrameTest, ReplaceNavigationAfterHistoryNavigation)

error.domain = "WebFrameTest";

std::string errorURL = "http://0.0.0.0";

WebURLResponse response;

- response.initialize();

response.setURL(URLTestHelpers::toKURL(errorURL));

response.setMIMEType("text/html");

response.setHTTPStatusCode(500);

@@ -5720,14 +5718,12 @@ TEST_P(ParameterizedWebFrameTest, FirstPartyForCookiesForRedirect)

char redirect[] = "http://internal.test/first_party.html";

WebURL redirectURL(toKURL(redirect));

WebURLResponse redirectResponse;

- redirectResponse.initialize();

redirectResponse.setMIMEType("text/html");

redirectResponse.setHTTPStatusCode(302);

redirectResponse.setHTTPHeaderField("Location", redirect);

Platform::current()->getURLLoaderMockFactory()->registerURL(testURL, redirectResponse, filePath);

WebURLResponse finalResponse;

- finalResponse.initialize();

finalResponse.setMIMEType("text/html");

Platform::current()->getURLLoaderMockFactory()->registerURL(redirectURL, finalResponse, filePath);