third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h - Issue 2117313002: Remove WebURLResponse::initialize() [revised]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h

Issue 2117313002: Remove WebURLResponse::initialize() [revised] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanups Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebURLResponse.cpp ('k') | third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h

diff --git a/third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h b/third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h

index 81cb5c0649e665bdd83a4d7fab1230c82061cd3c..1f068fa18c8c15d42c5905eeb72019bd9ae71bf3 100644

--- a/third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h

+++ b/third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h

@@ -41,10 +41,8 @@ class ResourceResponse;

class WebURLResponsePrivate {

WTF_MAKE_NONCOPYABLE(WebURLResponsePrivate);

public:

- WebURLResponsePrivate() : m_resourceResponse(0) { }

- // Called by WebURLResponse when it no longer needs this object.

- virtual void dispose() = 0;

+ WebURLResponsePrivate() : m_resourceResponse(nullptr) {}

+ virtual ~WebURLResponsePrivate() {}

ResourceResponse* m_resourceResponse;

};