Remove WebURLResponse::initialize() [revised]

third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
 #define WrappedResourceResponse_h
 
 #include "platform/exported/WebURLResponsePrivate.h"
 #include "public/platform/WebURLResponse.h"
 #include "wtf/Allocator.h"
 
 namespace blink {
 
 class WrappedResourceResponse : public WebURLResponse {
 public:
-    ~WrappedResourceResponse()
+    ~WrappedResourceResponse() {}
+    WrappedResourceResponse() : WebURLResponse(&m_handle) {}
+
+    explicit WrappedResourceResponse(ResourceResponse& resourceResponse)
+        : WebURLResponse(&m_handle)
     {
-        reset(); // Need to drop reference to m_handle
+        m_handle.setResourceResponse(resourceResponse);
     }
 
-    WrappedResourceResponse() { }
-
-    WrappedResourceResponse(ResourceResponse& resourceResponse)
+    explicit WrappedResourceResponse(const ResourceResponse& resourceResponse)
+        : WrappedResourceResponse(const_cast<ResourceResponse&>(resourceResponse))
     {
-        bind(resourceResponse);
-    }
-
-    WrappedResourceResponse(const ResourceResponse& resourceResponse)
-    {
-        bind(resourceResponse);
-    }
-
-    void bind(ResourceResponse& resourceResponse)
-    {
-        m_handle.m_resourceResponse = &resourceResponse;
-        assign(&m_handle);
     }
 
     void bind(const ResourceResponse& resourceResponse)
     {
-        bind(*const_cast<ResourceResponse*>(&resourceResponse));
+        m_handle.setResourceResponse(resourceResponse);
     }
 
 private:
     class Handle : public WebURLResponsePrivate {
         DISALLOW_NEW();
     public:
-        virtual void dispose() { m_resourceResponse = 0; }
+        const ResourceResponse* resourceResponse() const override
+        {
+            return m_resourceResponse;
+        }
+
+        ResourceResponse* resourceResponse() override
+        {
+            return m_resourceResponse;

[Adam Rice, 2016/07/06 01:39:00]

We could optionally track whether the ResourceResponse was originally const and
DCHECK() here. In other words, moving the const checking we lost at compile time
to runtime.

+        }
+
+        void setResourceResponse(const ResourceResponse& response) override
+        {
+            m_resourceResponse = const_cast<ResourceResponse*>(&response);
+        }
+
+    private:
+        ResourceResponse* m_resourceResponse = nullptr;
     };
 
     Handle m_handle;
 };
 
 } // namespace blink
 
 #endif