Remove WebURLResponse::initialize() [revised]

third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "public/platform/WebString.h"
 #include "wtf/Noncopyable.h"
 
 namespace blink {
 
 class ResourceResponse;
 
 class WebURLResponsePrivate {
     WTF_MAKE_NONCOPYABLE(WebURLResponsePrivate);
 public:
-    WebURLResponsePrivate() : m_resourceResponse(0) { }
+    WebURLResponsePrivate() {}
+    virtual ~WebURLResponsePrivate() {}
 
-    // Called by WebURLResponse when it no longer needs this object.
-    virtual void dispose() = 0;
-
-    ResourceResponse* m_resourceResponse;
+    virtual const ResourceResponse* resourceResponse() const = 0;
+    virtual ResourceResponse* resourceResponse() = 0;

[Adam Rice, 2016/07/06 01:39:00]

I have been assuming that whoever originally wrote this was trying to avoid
virtual method dispatch on the regular setters and getters. Otherwise why make
it so complicated?

They might have been wrong about the need for this optimisation, but they might
have been right.

[kinuko, 2016/07/06 09:45:57]

That might be the case (given that WebKit code base generally tried to avoid
doing that), but it's making the code harder to read.  I could revert this part
though and try to land it separately (so that we can easily revert this specific
change if we see any regression)

[Adam Rice, 2016/07/06 10:06:50]

I think makes sense to split out the removal of initialize() from the
refactoring so we have less to revert if we see a regression.

+    virtual void setResourceResponse(const ResourceResponse& response) = 0;
 };
 
 } // namespace blink
 
 #endif