Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2117303003: [debugger] add test case for throwing in generators. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] add test case for throwing in generators. R=neis@chromium.org Committed: https://crrev.com/7a834e8b69c8586a025a529873440826f95830db Cr-Commit-Position: refs/heads/master@{#37520}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
A test/mjsunit/es6/debug-exception-generators.js View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
4 years, 5 months ago (2016-07-05 09:16:54 UTC) #1
neis
lgtm https://codereview.chromium.org/2117303003/diff/1/test/mjsunit/es6/debug-exception-generators.js File test/mjsunit/es6/debug-exception-generators.js (right): https://codereview.chromium.org/2117303003/diff/1/test/mjsunit/es6/debug-exception-generators.js#newcode41 test/mjsunit/es6/debug-exception-generators.js:41: assertEquals(2, g_obj.throw("a").value); The arguments to throw are a ...
4 years, 5 months ago (2016-07-05 09:30:51 UTC) #2
Yang
On 2016/07/05 09:30:51, neis wrote: > lgtm > > https://codereview.chromium.org/2117303003/diff/1/test/mjsunit/es6/debug-exception-generators.js > File test/mjsunit/es6/debug-exception-generators.js (right): > ...
4 years, 5 months ago (2016-07-05 09:45:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117303003/20001
4 years, 5 months ago (2016-07-05 09:46:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 10:10:37 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 10:12:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a834e8b69c8586a025a529873440826f95830db
Cr-Commit-Position: refs/heads/master@{#37520}

Powered by Google App Engine
This is Rietveld 408576698