Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/debug/mirrors.js

Issue 2117273002: Revert of [intrinsic] Drop the %_ValueOf intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/mirrors.js
diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js
index adf5133da5e9f7961d8017f5c634f612de498659..2e7920d9b4ff4d9a27f28944f7d5d128eac8d683 100644
--- a/src/debug/mirrors.js
+++ b/src/debug/mirrors.js
@@ -19,6 +19,7 @@
var promiseResultSymbol = utils.ImportNow("promise_result_symbol");
var SetIteratorNext;
var SetValues;
+var SymbolToString;
utils.Import(function(from) {
ErrorToString = from.ErrorToString;
@@ -27,6 +28,7 @@
MapIteratorNext = from.MapIteratorNext;
SetIteratorNext = from.SetIteratorNext;
SetValues = from.SetValues;
+ SymbolToString = from.SymbolToString;
});
// ----------------------------------------------------------------------------
@@ -684,12 +686,12 @@
SymbolMirror.prototype.description = function() {
- return %SymbolDescription(%ValueOf(this.value_));
+ return %SymbolDescription(%_ValueOf(this.value_));
}
SymbolMirror.prototype.toText = function() {
- return %SymbolDescriptiveString(%ValueOf(this.value_));
+ return %_Call(SymbolToString, this.value_);
}
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698