Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: src/debug/mirrors.js

Issue 2117273002: Revert of [intrinsic] Drop the %_ValueOf intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2012 the V8 project authors. All rights reserved. 1 // Copyright 2006-2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
11 var ErrorToString; 11 var ErrorToString;
12 var GlobalArray = global.Array; 12 var GlobalArray = global.Array;
13 var IsNaN = global.isNaN; 13 var IsNaN = global.isNaN;
14 var JSONStringify = global.JSON.stringify; 14 var JSONStringify = global.JSON.stringify;
15 var MakeError; 15 var MakeError;
16 var MapEntries; 16 var MapEntries;
17 var MapIteratorNext; 17 var MapIteratorNext;
18 var promiseStateSymbol = utils.ImportNow("promise_state_symbol"); 18 var promiseStateSymbol = utils.ImportNow("promise_state_symbol");
19 var promiseResultSymbol = utils.ImportNow("promise_result_symbol"); 19 var promiseResultSymbol = utils.ImportNow("promise_result_symbol");
20 var SetIteratorNext; 20 var SetIteratorNext;
21 var SetValues; 21 var SetValues;
22 var SymbolToString;
22 23
23 utils.Import(function(from) { 24 utils.Import(function(from) {
24 ErrorToString = from.ErrorToString; 25 ErrorToString = from.ErrorToString;
25 MakeError = from.MakeError; 26 MakeError = from.MakeError;
26 MapEntries = from.MapEntries; 27 MapEntries = from.MapEntries;
27 MapIteratorNext = from.MapIteratorNext; 28 MapIteratorNext = from.MapIteratorNext;
28 SetIteratorNext = from.SetIteratorNext; 29 SetIteratorNext = from.SetIteratorNext;
29 SetValues = from.SetValues; 30 SetValues = from.SetValues;
31 SymbolToString = from.SymbolToString;
30 }); 32 });
31 33
32 // ---------------------------------------------------------------------------- 34 // ----------------------------------------------------------------------------
33 35
34 // Mirror hierarchy: 36 // Mirror hierarchy:
35 // - Mirror 37 // - Mirror
36 // - ValueMirror 38 // - ValueMirror
37 // - UndefinedMirror 39 // - UndefinedMirror
38 // - NullMirror 40 // - NullMirror
39 // - BooleanMirror 41 // - BooleanMirror
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 * @constructor 679 * @constructor
678 * @extends Mirror 680 * @extends Mirror
679 */ 681 */
680 function SymbolMirror(value) { 682 function SymbolMirror(value) {
681 %_Call(ValueMirror, this, MirrorType.SYMBOL_TYPE, value); 683 %_Call(ValueMirror, this, MirrorType.SYMBOL_TYPE, value);
682 } 684 }
683 inherits(SymbolMirror, ValueMirror); 685 inherits(SymbolMirror, ValueMirror);
684 686
685 687
686 SymbolMirror.prototype.description = function() { 688 SymbolMirror.prototype.description = function() {
687 return %SymbolDescription(%ValueOf(this.value_)); 689 return %SymbolDescription(%_ValueOf(this.value_));
688 } 690 }
689 691
690 692
691 SymbolMirror.prototype.toText = function() { 693 SymbolMirror.prototype.toText = function() {
692 return %SymbolDescriptiveString(%ValueOf(this.value_)); 694 return %_Call(SymbolToString, this.value_);
693 } 695 }
694 696
695 697
696 /** 698 /**
697 * Mirror object for objects. 699 * Mirror object for objects.
698 * @param {object} value The object reflected by this mirror 700 * @param {object} value The object reflected by this mirror
699 * @param {boolean} transient indicate whether this object is transient with a 701 * @param {boolean} transient indicate whether this object is transient with a
700 * transient handle 702 * transient handle
701 * @constructor 703 * @constructor
702 * @extends ValueMirror 704 * @extends ValueMirror
(...skipping 2342 matching lines...) Expand 10 before | Expand all | Expand 10 after
3045 // Functions needed by the debugger runtime. 3047 // Functions needed by the debugger runtime.
3046 utils.InstallFunctions(utils, DONT_ENUM, [ 3048 utils.InstallFunctions(utils, DONT_ENUM, [
3047 "ClearMirrorCache", ClearMirrorCache 3049 "ClearMirrorCache", ClearMirrorCache
3048 ]); 3050 ]);
3049 3051
3050 // Export to debug.js 3052 // Export to debug.js
3051 utils.Export(function(to) { 3053 utils.Export(function(to) {
3052 to.MirrorType = MirrorType; 3054 to.MirrorType = MirrorType;
3053 }); 3055 });
3054 }) 3056 })
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698