Revert of [intrinsic] Drop the %_ValueOf intrinsic.

src/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins.h"
 
 #include "src/api-arguments.h"
 #include "src/api-natives.h"
 #include "src/api.h"
 #include "src/base/ieee754.h"
@@ skipping 2225 matching lines @@
   HandleScope scope(isolate);
   JsonStringifier stringifier(isolate);
   Handle<Object> object = args.atOrUndefined(isolate, 1);
   Handle<Object> replacer = args.atOrUndefined(isolate, 2);
   Handle<Object> indent = args.atOrUndefined(isolate, 3);
   RETURN_RESULT_OR_FAILURE(isolate,
                            stringifier.Stringify(object, replacer, indent));
 }
 
 // -----------------------------------------------------------------------------
-// ES6 section 20.1 Number Objects
-
-// ES6 section 20.1.3.2 Number.prototype.toExponential ( fractionDigits )
-BUILTIN(NumberPrototypeToExponential) {
-  HandleScope scope(isolate);
-  Handle<Object> value = args.at<Object>(0);
-  Handle<Object> fraction_digits = args.atOrUndefined(isolate, 1);
-
-  // Unwrap the receiver {value}.
-  if (value->IsJSValue()) {
-    value = handle(Handle<JSValue>::cast(value)->value(), isolate);
-  }
-  if (!value->IsNumber()) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewTypeError(MessageTemplate::kNotGeneric,
-                              isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toExponential")));
-  }
-  double const value_number = value->Number();
-
-  // Convert the {fraction_digits} to an integer first.
-  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
-      isolate, fraction_digits, Object::ToInteger(isolate, fraction_digits));
-  double const fraction_digits_number = fraction_digits->Number();
-
-  if (std::isnan(value_number)) return isolate->heap()->nan_string();
-  if (std::isinf(value_number)) {
-    return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
-                                : isolate->heap()->infinity_string();
-  }
-  if (fraction_digits_number < 0.0 || fraction_digits_number > 20.0) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewRangeError(MessageTemplate::kNumberFormatRange,
-                               isolate->factory()->NewStringFromAsciiChecked(
-                                   "toExponential()")));
-  }
-  int const f = args.atOrUndefined(isolate, 1)->IsUndefined(isolate)
-                    ? -1
-                    : static_cast<int>(fraction_digits_number);
-  char* const str = DoubleToExponentialCString(value_number, f);
-  Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
-  DeleteArray(str);
-  return *result;
-}
-
-// ES6 section 20.1.3.3 Number.prototype.toFixed ( fractionDigits )
-BUILTIN(NumberPrototypeToFixed) {
-  HandleScope scope(isolate);
-  Handle<Object> value = args.at<Object>(0);
-  Handle<Object> fraction_digits = args.atOrUndefined(isolate, 1);
-
-  // Unwrap the receiver {value}.
-  if (value->IsJSValue()) {
-    value = handle(Handle<JSValue>::cast(value)->value(), isolate);
-  }
-  if (!value->IsNumber()) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewTypeError(MessageTemplate::kNotGeneric,
-                              isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toFixed")));
-  }
-  double const value_number = value->Number();
-
-  // Convert the {fraction_digits} to an integer first.
-  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
-      isolate, fraction_digits, Object::ToInteger(isolate, fraction_digits));
-  double const fraction_digits_number = fraction_digits->Number();
-
-  // Check if the {fraction_digits} are in the supported range.
-  if (fraction_digits_number < 0.0 || fraction_digits_number > 20.0) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewRangeError(MessageTemplate::kNumberFormatRange,
-                               isolate->factory()->NewStringFromAsciiChecked(
-                                   "toFixed() digits")));
-  }
-
-  if (std::isnan(value_number)) return isolate->heap()->nan_string();
-  if (std::isinf(value_number)) {
-    return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
-                                : isolate->heap()->infinity_string();
-  }
-  char* const str = DoubleToFixedCString(
-      value_number, static_cast<int>(fraction_digits_number));
-  Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
-  DeleteArray(str);
-  return *result;
-}
-
-// ES6 section 20.1.3.5 Number.prototype.toPrecision ( precision )
-BUILTIN(NumberPrototypeToPrecision) {
-  HandleScope scope(isolate);
-  Handle<Object> value = args.at<Object>(0);
-  Handle<Object> precision = args.atOrUndefined(isolate, 1);
-
-  // Unwrap the receiver {value}.
-  if (value->IsJSValue()) {
-    value = handle(Handle<JSValue>::cast(value)->value(), isolate);
-  }
-  if (!value->IsNumber()) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewTypeError(MessageTemplate::kNotGeneric,
-                              isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toPrecision")));
-  }
-  double const value_number = value->Number();
-
-  // If no {precision} was specified, just return ToString of {value}.
-  if (precision->IsUndefined(isolate)) {
-    return *isolate->factory()->NumberToString(value);
-  }
-
-  // Convert the {precision} to an integer first.
-  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, precision,
-                                     Object::ToInteger(isolate, precision));
-  double const precision_number = precision->Number();
-
-  if (std::isnan(value_number)) return isolate->heap()->nan_string();
-  if (std::isinf(value_number)) {
-    return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
-                                : isolate->heap()->infinity_string();
-  }
-  if (precision_number < 1.0 || precision_number > 21.0) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewRangeError(MessageTemplate::kToPrecisionFormatRange));
-  }
-  char* const str = DoubleToPrecisionCString(
-      value_number, static_cast<int>(precision_number));
-  Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
-  DeleteArray(str);
-  return *result;
-}
-
-// ES6 section 20.1.3.6 Number.prototype.toString ( [ radix ] )
-BUILTIN(NumberPrototypeToString) {
-  HandleScope scope(isolate);
-  Handle<Object> value = args.at<Object>(0);
-  Handle<Object> radix = args.atOrUndefined(isolate, 1);
-
-  // Unwrap the receiver {value}.
-  if (value->IsJSValue()) {
-    value = handle(Handle<JSValue>::cast(value)->value(), isolate);
-  }
-  if (!value->IsNumber()) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewTypeError(MessageTemplate::kNotGeneric,
-                              isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toString")));
-  }
-  double const value_number = value->Number();
-
-  // If no {radix} was specified, just return ToString of {value}.
-  if (radix->IsUndefined(isolate)) {
-    return *isolate->factory()->NumberToString(value);
-  }
-
-  // Convert the {radix} to an integer first.
-  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, radix,
-                                     Object::ToInteger(isolate, radix));
-  double const radix_number = radix->Number();
-
-  // If {radix} is 10, just return ToString of {value}.
-  if (radix_number == 10.0) return *isolate->factory()->NumberToString(value);
-
-  // Make sure the {radix} is within the valid range.
-  if (radix_number < 2.0 || radix_number > 36.0) {
-    THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewRangeError(MessageTemplate::kToRadixFormatRange));
-  }
-
-  // Fast case where the result is a one character string.
-  if (IsUint32Double(value_number) && value_number < radix_number) {
-    // Character array used for conversion.
-    static const char kCharTable[] = "0123456789abcdefghijklmnopqrstuvwxyz";
-    return *isolate->factory()->LookupSingleCharacterStringFromCode(
-        kCharTable[static_cast<uint32_t>(value_number)]);
-  }
-
-  // Slow case.
-  if (std::isnan(value_number)) return isolate->heap()->nan_string();
-  if (std::isinf(value_number)) {
-    return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
-                                : isolate->heap()->infinity_string();
-  }
-  char* const str =
-      DoubleToRadixCString(value_number, static_cast<int>(radix_number));
-  Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
-  DeleteArray(str);
-  return *result;
-}
-
-// ES6 section 20.1.3.7 Number.prototype.valueOf ( )
-void Builtins::Generate_NumberPrototypeValueOf(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
-
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* result = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kNumber, "Number.prototype.valueOf");
-  assembler->Return(result);
-}
-
-// -----------------------------------------------------------------------------
 // ES6 section 20.2.2 Function Properties of the Math Object
 
 // ES6 section - 20.2.2.1 Math.abs ( x )
 void Builtins::Generate_MathAbs(CodeStubAssembler* assembler) {
   using compiler::Node;
   Node* x = assembler->Parameter(1);
   Node* context = assembler->Parameter(4);
   Node* x_value = assembler->TruncateTaggedToFloat64(context, x);
   Node* value = assembler->Float64Abs(x_value);
   Node* result = assembler->ChangeFloat64ToTagged(value);
@@ skipping 938 matching lines @@
   Handle<JSObject> result;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result,
                                      JSObject::New(target, new_target));
   Handle<JSValue>::cast(result)->set_value(
       isolate->heap()->ToBoolean(value->BooleanValue()));
   return *result;
 }
 
 
 // ES6 section 19.3.3.2 Boolean.prototype.toString ( )
-void Builtins::Generate_BooleanPrototypeToString(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
-
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* value = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kBoolean, "Boolean.prototype.toString");
-  Node* result = assembler->LoadObjectField(value, Oddball::kToStringOffset);
-  assembler->Return(result);
+BUILTIN(BooleanPrototypeToString) {
+  HandleScope scope(isolate);
+  Handle<Object> receiver = args.receiver();
+  if (receiver->IsJSValue()) {
+    receiver = handle(Handle<JSValue>::cast(receiver)->value(), isolate);
+  }
+  if (!receiver->IsBoolean()) {
+    THROW_NEW_ERROR_RETURN_FAILURE(
+        isolate, NewTypeError(MessageTemplate::kNotGeneric,
+                              isolate->factory()->NewStringFromAsciiChecked(
+                                  "Boolean.prototype.toString")));
+  }
+  return Handle<Oddball>::cast(receiver)->to_string();
 }
 
+
 // ES6 section 19.3.3.3 Boolean.prototype.valueOf ( )
-void Builtins::Generate_BooleanPrototypeValueOf(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
+BUILTIN(BooleanPrototypeValueOf) {
+  HandleScope scope(isolate);
+  Handle<Object> receiver = args.receiver();
+  if (receiver->IsJSValue()) {
+    receiver = handle(Handle<JSValue>::cast(receiver)->value(), isolate);
+  }
+  if (!receiver->IsBoolean()) {
+    THROW_NEW_ERROR_RETURN_FAILURE(
+        isolate, NewTypeError(MessageTemplate::kNotGeneric,
+                              isolate->factory()->NewStringFromAsciiChecked(
+                                  "Boolean.prototype.valueOf")));
+  }
+  return *receiver;
+}
 
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* result = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kBoolean, "Boolean.prototype.valueOf");
-  assembler->Return(result);
-}
 
 // -----------------------------------------------------------------------------
 // ES6 section 24.2 DataView Objects
 
 
 // ES6 section 24.2.2 The DataView Constructor for the [[Call]] case.
 BUILTIN(DataViewConstructor) {
   HandleScope scope(isolate);
   THROW_NEW_ERROR_RETURN_FAILURE(
       isolate,
@@ skipping 1516 matching lines @@
 
   // Do not lazily compute eval position for AsyncFunction, as they may not be
   // determined after the function is resumed.
   Handle<Script> script = handle(Script::cast(func->shared()->script()));
   int position = script->GetEvalPosition();
   USE(position);
 
   return *func;
 }
 
-// ES6 19.1.3.6 Object.prototype.toString
-BUILTIN(ObjectProtoToString) {
-  HandleScope scope(isolate);
-  Handle<Object> object = args.at<Object>(0);
-  RETURN_RESULT_OR_FAILURE(isolate,
-                           Object::ObjectProtoToString(isolate, object));
-}
-
-// -----------------------------------------------------------------------------
-// ES6 section 19.4 Symbol Objects
-
 // ES6 section 19.4.1.1 Symbol ( [ description ] ) for the [[Call]] case.
 BUILTIN(SymbolConstructor) {
   HandleScope scope(isolate);
   Handle<Symbol> result = isolate->factory()->NewSymbol();
   Handle<Object> description = args.atOrUndefined(isolate, 1);
   if (!description->IsUndefined(isolate)) {
     ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, description,
                                        Object::ToString(isolate, description));
     result->set_name(*description);
   }
   return *result;
 }
 
 
 // ES6 section 19.4.1.1 Symbol ( [ description ] ) for the [[Construct]] case.
 BUILTIN(SymbolConstructor_ConstructStub) {
   HandleScope scope(isolate);
   THROW_NEW_ERROR_RETURN_FAILURE(
       isolate, NewTypeError(MessageTemplate::kNotConstructor,
                             isolate->factory()->Symbol_string()));
 }
 
-// ES6 section 19.4.3.4 Symbol.prototype [ @@toPrimitive ] ( hint )
-void Builtins::Generate_SymbolPrototypeToPrimitive(
-    CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
 
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(4);
-
-  Node* result =
-      assembler->ToThisValue(context, receiver, PrimitiveType::kSymbol,
-                             "Symbol.prototype [ @@toPrimitive ]");
-  assembler->Return(result);
-}
-
-// ES6 section 19.4.3.2 Symbol.prototype.toString ( )
-void Builtins::Generate_SymbolPrototypeToString(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
-
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* value = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kSymbol, "Symbol.prototype.toString");
-  Node* result =
-      assembler->CallRuntime(Runtime::kSymbolDescriptiveString, context, value);
-  assembler->Return(result);
-}
-
-// ES6 section 19.4.3.3 Symbol.prototype.valueOf ( )
-void Builtins::Generate_SymbolPrototypeValueOf(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
-
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* result = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kSymbol, "Symbol.prototype.valueOf");
-  assembler->Return(result);
+// ES6 19.1.3.6 Object.prototype.toString
+BUILTIN(ObjectProtoToString) {
+  HandleScope scope(isolate);
+  Handle<Object> object = args.at<Object>(0);
+  RETURN_RESULT_OR_FAILURE(isolate,
+                           Object::ObjectProtoToString(isolate, object));
 }
 
 // -----------------------------------------------------------------------------
 // ES6 section 21.1 String Objects
 
 // ES6 section 21.1.2.1 String.fromCharCode ( ...codeUnits )
 void Builtins::Generate_StringFromCharCode(CodeStubAssembler* assembler) {
   typedef CodeStubAssembler::Label Label;
   typedef compiler::Node Node;
   typedef CodeStubAssembler::Variable Variable;
@@ skipping 452 matching lines @@
     assembler->Return(assembler->NaNConstant());
     assembler->Bind(&if_positioninbounds);
   }
 
   // Load the character at the {position} from the {receiver}.
   Node* value = assembler->StringCharCodeAt(receiver, position);
   Node* result = assembler->SmiFromWord32(value);
   assembler->Return(result);
 }
 
-// ES6 section 21.1.3.25 String.prototype.toString ()
-void Builtins::Generate_StringPrototypeToString(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
-
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* result = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kString, "String.prototype.toString");
-  assembler->Return(result);
-}
-
-// ES6 section 21.1.3.27 String.prototype.trim ()
+// ES6 section 21.1.3.25 String.prototype.trim ()
 BUILTIN(StringPrototypeTrim) {
   HandleScope scope(isolate);
   TO_THIS_STRING(string, "String.prototype.trim");
   return *String::Trim(string, String::kTrim);
 }
 
 // Non-standard WebKit extension
 BUILTIN(StringPrototypeTrimLeft) {
   HandleScope scope(isolate);
   TO_THIS_STRING(string, "String.prototype.trimLeft");
   return *String::Trim(string, String::kTrimLeft);
 }
 
 // Non-standard WebKit extension
 BUILTIN(StringPrototypeTrimRight) {
   HandleScope scope(isolate);
   TO_THIS_STRING(string, "String.prototype.trimRight");
   return *String::Trim(string, String::kTrimRight);
 }
 
-// ES6 section 21.1.3.28 String.prototype.valueOf ( )
-void Builtins::Generate_StringPrototypeValueOf(CodeStubAssembler* assembler) {
-  typedef compiler::Node Node;
-
-  Node* receiver = assembler->Parameter(0);
-  Node* context = assembler->Parameter(3);
-
-  Node* result = assembler->ToThisValue(
-      context, receiver, PrimitiveType::kString, "String.prototype.valueOf");
-  assembler->Return(result);
-}
-
 // -----------------------------------------------------------------------------
 // ES6 section 21.1 ArrayBuffer Objects
 
 // ES6 section 24.1.2.1 ArrayBuffer ( length ) for the [[Call]] case.
 BUILTIN(ArrayBufferConstructor) {
   HandleScope scope(isolate);
   Handle<JSFunction> target = args.target<JSFunction>();
   DCHECK(*target == target->native_context()->array_buffer_fun() ||
          *target == target->native_context()->shared_array_buffer_fun());
   THROW_NEW_ERROR_RETURN_FAILURE(
@@ skipping 1122 matching lines @@
 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
 #undef DEFINE_BUILTIN_ACCESSOR_C
 #undef DEFINE_BUILTIN_ACCESSOR_A
 #undef DEFINE_BUILTIN_ACCESSOR_T
 #undef DEFINE_BUILTIN_ACCESSOR_S
 #undef DEFINE_BUILTIN_ACCESSOR_H
 
 }  // namespace internal
 }  // namespace v8