Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2117273002: Revert of [intrinsic] Drop the %_ValueOf intrinsic. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [intrinsic] Drop the %_ValueOf intrinsic. (patchset #2 id:20001 of https://codereview.chromium.org/2126453002/ ) Reason for revert: [Sheriff] Breaks without i18n: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/8466 Original issue's description: > [intrinsic] Drop the %_ValueOf intrinsic. > > This drops the %_ValueOf intrinsic, but keeps the runtime entry > %ValueOf for now, by either migrating the functionality (mostly > Debug mirror or toString/valueOf methods) to C++ or TurboFan > builtins, or switching to the %ValueOf runtime call when it's > not performance critical anyways. > > The %_ValueOf intrinsic was one of the last blockers for fixing > the unsound machine operator typing in TurboFan. > > R=yangguo@chromium.org > BUG=v8:5049 > > Committed: https://crrev.com/293bd7882987f00e465710ce468bfb1eaa7d3fa2 > Cr-Commit-Position: refs/heads/master@{#37512} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5049 Committed: https://crrev.com/0960beb0ef4e404031a194a80599acaf79414e31 Cr-Commit-Position: refs/heads/master@{#37514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+706 lines, -485 lines) Patch
M src/bootstrapper.cc View 4 chunks +2 lines, -57 lines 0 comments Download
M src/builtins.h View 7 chunks +2 lines, -31 lines 0 comments Download
M src/builtins.cc View 6 chunks +38 lines, -298 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +66 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M src/debug/mirrors.js View 3 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/js/harmony-simd.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/macros.py View 4 chunks +9 lines, -0 lines 0 comments Download
M src/js/messages.js View 3 chunks +3 lines, -1 line 0 comments Download
M src/js/prologue.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/string.js View 2 chunks +20 lines, -0 lines 0 comments Download
M src/js/symbol.js View 2 chunks +47 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +135 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +84 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-valueof.js View 1 chunk +35 lines, -0 lines 0 comments Download
M test/mjsunit/error-tostring-omit.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [intrinsic] Drop the %_ValueOf intrinsic.
4 years, 5 months ago (2016-07-05 07:59:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117273002/1
4 years, 5 months ago (2016-07-05 07:59:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 07:59:58 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 08:01:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0960beb0ef4e404031a194a80599acaf79414e31
Cr-Commit-Position: refs/heads/master@{#37514}

Powered by Google App Engine
This is Rietveld 408576698