Duplicate payment method identifiers in methodData and details.modififiers should throw TypeError.

third_party/WebKit/LayoutTests/payments/payment-request-interface.html

Index: third_party/WebKit/LayoutTests/payments/payment-request-interface.html
diff --git a/third_party/WebKit/LayoutTests/payments/payment-request-interface.html b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
index 29e70b7c11e748af6af07cfe74bb5612a7e5d9b2..15fd1cd45e9b380a585f5e9d4f1bfc80cab75d33 100644
--- a/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
+++ b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
@@ -206,6 +206,18 @@ test(function() {
 
 test(function() {
     assert_throws(new TypeError(), function() {
+        new PaymentRequest([{'supportedMethods': ['foo']}], {'total': buildItem(), 'modifiers': [{'supportedMethods': ['foo', 'foo']}]});
+    });
+}, 'Duplicate supported payment method identifiers in modifiers should throw TypeError.');
+
+test(function() {
+    assert_throws(new TypeError(), function() {
+        new PaymentRequest([{'supportedMethods': ['foo']}], {'total': buildItem(), 'modifiers': [{'supportedMethods': ['foo']}, {'supportedMethods': ['foo']}]});
+    });
+}, 'Duplicate supported payment method identifiers in modifiers should throw TypeError.');

[please use gerrit instead, 2016/07/06 07:31:56]

Can you put your assert_throws() tests together inside of the generate_tests()
below? That saves 50% of lines of code. I'm not sure why the other
assert_throws() tests are not in the generate_tests(), but you don't have to fix
them in your patch.

[pals, 2016/07/07 05:14:13]

Done.

+
+test(function() {
+    assert_throws(new TypeError(), function() {
         new PaymentRequest([{'supportedMethods': ['foo']}], {'total': buildItem(), 'modifiers': [{'supportedMethods': undefined}]});
     });
 }, 'Undefined supportedMethods in modifiers should throw TypeError.');
@@ -243,6 +255,12 @@ generate_tests(assert_throws, [
     ['Empty list of supported payment method identifiers should throw TypeError.', new TypeError(), function() {
         new PaymentRequest([], buildDetails())
     }],
+    ['Duplicate supported payment method identifiers should throw TypeError.', null, function() {
+        new PaymentRequest([{'supportedMethods': ['foo', 'foo']}], buildDetails(), {})
+    }],
+    ['Duplicate supported payment method identifiers should throw TypeError.', null, function() {
+        new PaymentRequest([{'supportedMethods': ['foo']}, {'supportedMethods': ['foo']}], buildDetails(), {})
+    }],
     ['Empty details should throw', null, function() {
         new PaymentRequest([{'supportedMethods': ['foo']}], {})
     }],