Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2117183006: gpu: Clarify sized texture format is available only if ES3 context or immutable texture is supported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sized format is available if es3 context or immutable texture Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 06ce1cef4294f85a4642eeb8d3bc751c37b3e05e..61bbc964346f8455a1e08bf4447680e791ccc999 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -651,7 +651,8 @@ void FeatureInfo::InitializeFeatures() {
// disable BGRA if we have to.
bool has_apple_bgra = extensions.Contains("GL_APPLE_texture_format_BGRA8888");
bool has_ext_bgra = extensions.Contains("GL_EXT_texture_format_BGRA8888");
- bool has_bgra = has_ext_bgra || has_apple_bgra || !gl_version_info_->is_es;
+ bool enable_texture_format_bgra8888 =
+ has_ext_bgra || has_apple_bgra || !gl_version_info_->is_es;
bool has_ext_texture_storage = extensions.Contains("GL_EXT_texture_storage");
bool has_arb_texture_storage = extensions.Contains("GL_ARB_texture_storage");
@@ -660,7 +661,6 @@ void FeatureInfo::InitializeFeatures() {
(has_ext_texture_storage || has_arb_texture_storage ||
gl_version_info_->is_es3 || gl_version_info_->IsAtLeastGL(4, 2));
- bool enable_texture_format_bgra8888 = has_bgra;
bool enable_texture_storage = has_texture_storage;
bool texture_storage_incompatible_with_bgra =
@@ -685,6 +685,14 @@ void FeatureInfo::InitializeFeatures() {
validators_.texture_internal_format.AddValue(GL_BGRA_EXT);
validators_.texture_format.AddValue(GL_BGRA_EXT);
validators_.texture_unsized_internal_format.AddValue(GL_BGRA_EXT);
+
+ if (IsES3Capable()) {
+ validators_.texture_internal_format.AddValue(GL_BGRA8_EXT);
+ validators_.texture_sized_color_renderable_internal_format.AddValue(
+ GL_BGRA8_EXT);
+ validators_.texture_sized_texture_filterable_internal_format.AddValue(
+ GL_BGRA8_EXT);
+ }
}
// On desktop, all devices support BGRA render buffers (note that on desktop
@@ -1104,8 +1112,20 @@ void FeatureInfo::InitializeFeatures() {
feature_flags_.ext_texture_storage = true;
AddExtensionString("GL_EXT_texture_storage");
validators_.texture_parameter.AddValue(GL_TEXTURE_IMMUTABLE_FORMAT_EXT);
- if (enable_texture_format_bgra8888)
- validators_.texture_internal_format_storage.AddValue(GL_BGRA8_EXT);
+ if (enable_texture_format_bgra8888) {
+ validators_.texture_internal_format_storage.AddValue(GL_BGRA8_EXT);
+ // It can be added above if the context is ES3 capable.
+ if (!validators_.texture_sized_color_renderable_internal_format.IsValid(
+ GL_BGRA8_EXT)) {
+ validators_.texture_sized_color_renderable_internal_format.AddValue(
+ GL_BGRA8_EXT);
+ }
+ if (!validators_.texture_sized_texture_filterable_internal_format.IsValid(
+ GL_BGRA8_EXT)) {
+ validators_.texture_sized_texture_filterable_internal_format.AddValue(
+ GL_BGRA8_EXT);
+ }
+ }
if (enable_texture_float) {
validators_.texture_internal_format_storage.AddValue(GL_RGBA32F_EXT);
validators_.texture_internal_format_storage.AddValue(GL_RGB32F_EXT);
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/texture_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698