Implement git cl upload --dry-run or --use-commit-queue for Gerrit.

Implement git cl upload --dry-run or --use-commit-queue for Gerrit.

Previously, it only worked for Rietveld.

BUG=622828
R=emso@chromium.org,machenbach@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4d0545a43968c2cf1d03f03df368da05c94a4a6e

[tandrii(chromium), 2016-07-05 21:50:26]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 21:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 21:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 21:54:07]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-07-05 22:00:14]

PTAL

[tandrii(chromium), 2016-07-05 22:00:14]

PTAL

[tandrii(chromium), 2016-07-05 22:00:15]

PTAL

[Michael Achenbach, 2016-07-06 07:30:39]

lgtm

https://codereview.chromium.org/2117183004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2117183004/diff/1/git_cl.py#newcode1419
git_cl.py:1419: ret = self.CMDUploadChange(options, git_diff_args, change)
Dumb question: How is 'self' referring to the 'impl' class? Got confused and
couldn't find again how it's wired together.

https://codereview.chromium.org/2117183004/diff/1/git_cl.py#newcode1421
git_cl.py:1421: if options.use_commit_queue:
nit: Maybe give dry-run precedence over commit? If somebody used both options
it's likely a mistake, but I'd interpret the appearance of the dry-run option as
the user not wanting to commit.

Or is there another place that makes sure not both options are used?

[tandrii(chromium), 2016-07-06 10:38:13]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 10:38:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-06 10:38:26]

https://codereview.chromium.org/2117183004/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2117183004/diff/1/git_cl.py#newcode1419
git_cl.py:1419: ret = self.CMDUploadChange(options, git_diff_args, change)
On 2016/07/06 07:30:39, Michael Achenbach wrote:
> Dumb question: How is 'self' referring to the 'impl' class? Got confused and
> couldn't find again how it's wired together.

__getattr__

https://codereview.chromium.org/2117183004/diff/1/git_cl.py#newcode1421
git_cl.py:1421: if options.use_commit_queue:
On 2016/07/06 07:30:39, Michael Achenbach wrote:
> nit: Maybe give dry-run precedence over commit? If somebody used both options
> it's likely a mistake, but I'd interpret the appearance of the dry-run option
as
> the user not wanting to commit.
> 
> Or is there another place that makes sure not both options are used?

added a check early on.

https://codereview.chromium.org/2117183004/diff/1/git_cl.py#newcode1479
git_cl.py:1479: return getattr(self._codereview_impl, attr)
this is the magic

[commit-bot: I haz the power, 2016-07-06 10:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 10:41:35]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-06 10:51:45]

lgtm

[tandrii(chromium), 2016-07-06 10:53:26]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-07-06 10:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 10:56:53]

Description was changed from

==========
Implement git cl upload --dry-run or --use-commit-queue for Gerrit.

Previously, it only worked for Rietveld.

BUG=622828
R=emso@chromium.org,machenbach@chromium.org
==========

to

==========
Implement git cl upload --dry-run or --use-commit-queue for Gerrit.

Previously, it only worked for Rietveld.

BUG=622828
R=emso@chromium.org,machenbach@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/4d0545a43968c2...
==========

[commit-bot: I haz the power, 2016-07-06 10:56:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/4d0545a43968c2...