Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2117183003: Fix left padding in the signin promo in the password bubble on Mac. (Closed)

Created:
4 years, 5 months ago by vasilii
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix left padding in the signin promo in the password bubble on Mac. BUG=615825 Committed: https://crrev.com/b0ca3a71dd593c4e447867179703e4dd8a65f50c Cr-Commit-Position: refs/heads/master@{#403789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vaclav, please review.
4 years, 5 months ago (2016-07-05 14:58:50 UTC) #2
vabr (Chromium)
LGTM, thanks! Vaclav
4 years, 5 months ago (2016-07-05 15:43:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117183003/1
4 years, 5 months ago (2016-07-05 16:18:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 16:22:29 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 16:25:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0ca3a71dd593c4e447867179703e4dd8a65f50c
Cr-Commit-Position: refs/heads/master@{#403789}

Powered by Google App Engine
This is Rietveld 408576698