Chromium Code Reviews

Issue 2117153002: 🎠 Have .apk targets copy .mapping file to apks/ directory (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Peter Wen, smaier
CC:
chromium-reviews, smaier
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have .apk targets copy .mapping file to apks/ directory This will make them available on builder/tester configurations (they are within gen/ at the moment). It will also make their location more obvious for archiving / de-obfuscating purposes. BUG=none Committed: https://crrev.com/19b7958ad4e0214898e8033c1ee908364ab20fb7 Cr-Commit-Position: refs/heads/master@{#403705}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+20 lines, -0 lines)
M build/config/android/rules.gni View 2 chunks +20 lines, -0 lines 0 comments

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117153002/1
4 years, 5 months ago (2016-07-04 17:35:51 UTC) #2
agrieve
On 2016/07/04 17:35:51, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 5 months ago (2016-07-04 17:36:26 UTC) #6
smaier
lgtm lgtm
4 years, 5 months ago (2016-07-04 17:43:50 UTC) #8
Peter Wen
lgtm
4 years, 5 months ago (2016-07-04 17:49:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117153002/1
4 years, 5 months ago (2016-07-04 18:01:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 18:37:10 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 18:37:14 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 18:39:17 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19b7958ad4e0214898e8033c1ee908364ab20fb7
Cr-Commit-Position: refs/heads/master@{#403705}

Powered by Google App Engine