third_party/WebKit/Source/build/scripts/make_style_builder.py - Issue 2117143003: Add a fast-path for independent inherited properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_style_builder.py

Issue 2117143003: Add a fast-path for independent inherited properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computedstyle_cleanup_rename_final_member_fields

Patch Set: Review feedback Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/css_properties.py ('k') | third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_style_builder.py

diff --git a/third_party/WebKit/Source/build/scripts/make_style_builder.py b/third_party/WebKit/Source/build/scripts/make_style_builder.py

index c5d5ca546fc202edd8a63c419f2ee7153b0b3ba1..1db728908137b0c1242498dfdb2e794e6ef8b6f9 100755

--- a/third_party/WebKit/Source/build/scripts/make_style_builder.py

+++ b/third_party/WebKit/Source/build/scripts/make_style_builder.py

@@ -59,11 +59,14 @@ class StyleBuilderWriter(css_properties.CSSProperties):

set_if_none(property, 'type_name', 'E' + name)

set_if_none(property, 'getter', lower_first(name) if simple_type_name != name else 'get' + name)

set_if_none(property, 'setter', 'set' + name)

+ set_if_none(property, 'inherited', False)

set_if_none(property, 'initial', 'initial' + name)

if property['custom_all']:

property['custom_initial'] = True

property['custom_inherit'] = True

property['custom_value'] = True

+ if property['inherited']:

+ property['is_inherited_setter'] = 'set' + name + 'IsInherited'

property['should_declare_functions'] = not property['use_handlers_for'] and not property['longhands'] \

and not property['direction_aware'] and not property['builder_skip'] \

and not property['descriptor_only']