Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 2117143003: Add a fast-path for independent inherited properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computedstyle_cleanup_rename_final_member_fields
Patch Set: Added useful sizeof check comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // This file specifies all the CSS properties we support and the necessary 1 // This file specifies all the CSS properties we support and the necessary
2 // information for our code generation. The various supported arguments 2 // information for our code generation. The various supported arguments
3 // are described below with example usage 3 // are described below with example usage
4 4
5 5
6 // - alias_for=other-property 6 // - alias_for=other-property
7 // Properties specifying alias_for should be virtually identical to the 7 // Properties specifying alias_for should be virtually identical to the
8 // properties they alias. Minor parsing differences are allowed as long as 8 // properties they alias. Minor parsing differences are allowed as long as
9 // the CSSValues created are of the same format of the aliased property. 9 // the CSSValues created are of the same format of the aliased property.
10 10
(...skipping 27 matching lines...) Expand all
38 // Flags which go into CSSPropertyMetadata: 38 // Flags which go into CSSPropertyMetadata:
39 // - interpolable 39 // - interpolable
40 // The interpolable flag indicates whether a property can be animated smoothly. 40 // The interpolable flag indicates whether a property can be animated smoothly.
41 // If this flag is set, the property should also be added to the switch 41 // If this flag is set, the property should also be added to the switch
42 // statements in AnimatedStyleBuilder, CSSPropertyEquality and 42 // statements in AnimatedStyleBuilder, CSSPropertyEquality and
43 // CSSAnimatableValueFactory. 43 // CSSAnimatableValueFactory.
44 // - inherited 44 // - inherited
45 // The property will inherit by default if no value is specified, typically 45 // The property will inherit by default if no value is specified, typically
46 // mentioned in specifications as "Inherited: yes" 46 // mentioned in specifications as "Inherited: yes"
47 47
48 // - independent
esprehn 2016/07/19 03:46:26 I think you want to mention that StyleAdjuster can
sashab 2016/07/19 06:32:38 Thanks :) Added that, and cleaned up this comment
49 // This property affects only one property on ComputedStyle, and can be
50 // set directly during inheritance instead of forcing a recalc.
51 // Recalcs only happen during a change propagation if at least one non-
52 // independent property is changed.
53 // Additionally, a change by an independent property must cause
Timothy Loh 2016/07/19 01:29:32 Why?
sashab 2016/07/19 03:31:34 Removed?
54 // ComputedStyle to change (e.g. font-size: 10px; and font-size: 1em;
esprehn 2016/07/19 03:46:26 I'm not sure this is a good example, font-size imp
sashab 2016/07/19 06:32:38 Removed this comment, its not really needed anyway
55 // result in the same ComputedStyle, but a change has still happened.
56 // To make font-size independent, more information about the original
57 // value needs to be stored).
48 58
49 // The remaining arguments are used for the StyleBuilder and allow us to 59 // The remaining arguments are used for the StyleBuilder and allow us to
50 // succinctly describe how to apply properties. When default handlers are not 60 // succinctly describe how to apply properties. When default handlers are not
51 // sufficient, we should prefer to use converter, and failing that define 61 // sufficient, we should prefer to use converter, and failing that define
52 // custom property handlers in StyleBuilderCustom.cpp. We only should use 62 // custom property handlers in StyleBuilderCustom.cpp. We only should use
53 // StyleBuilderFunctions.cpp.tmpl to define handlers when there are multiple 63 // StyleBuilderFunctions.cpp.tmpl to define handlers when there are multiple
54 // properties requiring the same handling, but converter doesn't suffice. 64 // properties requiring the same handling, but converter doesn't suffice.
55 65
56 // - font 66 // - font
57 // The default property handlers call into the FontBuilder instead of setting 67 // The default property handlers call into the FontBuilder instead of setting
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 overflow-wrap inherited 274 overflow-wrap inherited
265 overflow-x type_name=EOverflow 275 overflow-x type_name=EOverflow
266 overflow-y type_name=EOverflow 276 overflow-y type_name=EOverflow
267 padding-bottom interpolable, initial=initialPadding, converter=convertLength 277 padding-bottom interpolable, initial=initialPadding, converter=convertLength
268 padding-left interpolable, initial=initialPadding, converter=convertLength 278 padding-left interpolable, initial=initialPadding, converter=convertLength
269 padding-right interpolable, initial=initialPadding, converter=convertLength 279 padding-right interpolable, initial=initialPadding, converter=convertLength
270 padding-top interpolable, initial=initialPadding, converter=convertLength 280 padding-top interpolable, initial=initialPadding, converter=convertLength
271 paint-order inherited, svg, converter=convertPaintOrder 281 paint-order inherited, svg, converter=convertPaintOrder
272 perspective interpolable, converter=convertPerspective 282 perspective interpolable, converter=convertPerspective
273 perspective-origin interpolable, converter=convertPosition 283 perspective-origin interpolable, converter=convertPosition
274 pointer-events inherited 284 pointer-events inherited, independent
275 position custom_inherit 285 position custom_inherit
276 quotes inherited, converter=convertQuotes 286 quotes inherited, converter=convertQuotes
277 resize custom_value 287 resize custom_value
278 right typedom_types=[Length], keywords=[auto], supports_percentage, interpolable , initial=initialOffset, converter=convertLengthOrAuto 288 right typedom_types=[Length], keywords=[auto], supports_percentage, interpolable , initial=initialOffset, converter=convertLengthOrAuto
279 r interpolable, svg, converter=convertLength 289 r interpolable, svg, converter=convertLength
280 rx interpolable, svg, converter=convertLengthOrAuto 290 rx interpolable, svg, converter=convertLengthOrAuto
281 ry interpolable, svg, converter=convertLengthOrAuto 291 ry interpolable, svg, converter=convertLengthOrAuto
282 scroll-behavior runtime_flag=CSSOMSmoothScroll, type_name=ScrollBehavior 292 scroll-behavior runtime_flag=CSSOMSmoothScroll, type_name=ScrollBehavior
283 scroll-snap-type runtime_flag=CSSScrollSnapPoints, type_name=ScrollSnapType 293 scroll-snap-type runtime_flag=CSSScrollSnapPoints, type_name=ScrollSnapType
284 scroll-snap-points-x runtime_flag=CSSScrollSnapPoints, converter=convertSnapPoin ts 294 scroll-snap-points-x runtime_flag=CSSScrollSnapPoints, converter=convertSnapPoin ts
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 translate runtime_flag=CSSIndependentTransformProperties, converter=convertTrans late, interpolable 338 translate runtime_flag=CSSIndependentTransformProperties, converter=convertTrans late, interpolable
329 rotate runtime_flag=CSSIndependentTransformProperties, converter=convertRotate, interpolable 339 rotate runtime_flag=CSSIndependentTransformProperties, converter=convertRotate, interpolable
330 scale runtime_flag=CSSIndependentTransformProperties, converter=convertScale, in terpolable 340 scale runtime_flag=CSSIndependentTransformProperties, converter=convertScale, in terpolable
331 transition-delay custom_all 341 transition-delay custom_all
332 transition-duration custom_all 342 transition-duration custom_all
333 transition-property custom_all 343 transition-property custom_all
334 transition-timing-function custom_all 344 transition-timing-function custom_all
335 unicode-bidi 345 unicode-bidi
336 vector-effect svg 346 vector-effect svg
337 vertical-align interpolable, custom_inherit, custom_value 347 vertical-align interpolable, custom_inherit, custom_value
338 visibility interpolable, inherited 348 visibility interpolable, inherited, independent
339 x interpolable, svg, converter=convertLength 349 x interpolable, svg, converter=convertLength
340 y interpolable, svg, converter=convertLength 350 y interpolable, svg, converter=convertLength
341 -webkit-appearance type_name=ControlPart 351 -webkit-appearance type_name=ControlPart
342 -webkit-app-region custom_all 352 -webkit-app-region custom_all
343 -webkit-background-clip use_handlers_for=CSSPropertyBackgroundClip 353 -webkit-background-clip use_handlers_for=CSSPropertyBackgroundClip
344 -webkit-background-origin use_handlers_for=CSSPropertyBackgroundOrigin 354 -webkit-background-origin use_handlers_for=CSSPropertyBackgroundOrigin
345 -webkit-border-horizontal-spacing interpolable, inherited, name_for_methods=Hori zontalBorderSpacing, converter=convertComputedLength<short> 355 -webkit-border-horizontal-spacing interpolable, inherited, name_for_methods=Hori zontalBorderSpacing, converter=convertComputedLength<short>
346 -webkit-border-image initial=initialNinePieceImage, custom_value 356 -webkit-border-image initial=initialNinePieceImage, custom_value
347 -webkit-border-vertical-spacing interpolable, inherited, name_for_methods=Vertic alBorderSpacing, converter=convertComputedLength<short> 357 -webkit-border-vertical-spacing interpolable, inherited, name_for_methods=Vertic alBorderSpacing, converter=convertComputedLength<short>
348 -webkit-box-align type_name=EBoxAlignment 358 -webkit-box-align type_name=EBoxAlignment
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 -webkit-shape-outside alias_for=shape-outside 589 -webkit-shape-outside alias_for=shape-outside
580 -webkit-text-size-adjust alias_for=text-size-adjust 590 -webkit-text-size-adjust alias_for=text-size-adjust
581 -webkit-transform alias_for=transform 591 -webkit-transform alias_for=transform
582 -webkit-transform-origin alias_for=transform-origin 592 -webkit-transform-origin alias_for=transform-origin
583 -webkit-transform-style alias_for=transform-style 593 -webkit-transform-style alias_for=transform-style
584 -webkit-transition alias_for=transition 594 -webkit-transition alias_for=transition
585 -webkit-transition-delay alias_for=transition-delay 595 -webkit-transition-delay alias_for=transition-delay
586 -webkit-transition-duration alias_for=transition-duration 596 -webkit-transition-duration alias_for=transition-duration
587 -webkit-transition-property alias_for=transition-property 597 -webkit-transition-property alias_for=transition-property
588 -webkit-transition-timing-function alias_for=transition-timing-function 598 -webkit-transition-timing-function alias_for=transition-timing-function
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698