Add a fast-path for independent inherited properties

third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

 {% from 'macros.tmpl' import license %}
 {#
     This file is for property handlers which use the templating engine to
     reduce (handwritten) code duplication.
 
     The `properties' dict can be used to access a property's parameters in
     jinja2 templates (i.e. setter, getter, initial, type_name)
 #}
 #include "StyleBuilderFunctions.h"
 
@@ skipping 25 matching lines @@
 state.style()->{{property.setter}}
 {%- endif %}
 {% endmacro %}
 {% macro convert_and_set_value(property) %}
 {% if property.converter %}
 {{set_value(property)}}(StyleBuilderConverter::{{property.converter}}(state, value));
 {%- else %}
 {{set_value(property)}}(toCSSPrimitiveValue(value).convertTo<{{property.type_name}}>());
 {%- endif %}
 {% endmacro %}
+{% macro set_is_inherited(property) %}
+state.style()->{{property.isInheritedSetter}}
+{% endmacro %}
 
 namespace blink {
 
 {% for property_id, property in properties.items() if property.should_declare_functions %}
 {% set apply_type = property.apply_type %}
 {% if not property.custom_initial %}
 {{declare_initial_function(property_id)}}
 {
     {% if property.svg %}
     {{set_value(property)}}(SVGComputedStyle::{{property.initial}}());
     {% elif property.font %}
     {{set_value(property)}}(FontBuilder::{{property.initial}}());
     {% else %}
     {{set_value(property)}}(ComputedStyle::{{property.initial}}());
     {% endif %}
+    {% if property.independent %}
+    {{set_is_inherited(property)}}(true);

[esprehn, 2016/07/19 03:46:26]

what is this code generating that you want to set true, false? It's hard to
understand what all is going on with the templates right here

[sashab, 2016/07/19 06:32:38]

It's setting that the property is inherited from its parent value, as opposed to
below where its setting that it's not inherited. Sorry if its not super clear,
trying to think of a way I can clean it up...

+    {% endif %}
 }
 
 {% endif %}
 {% if not property.custom_inherit %}
 {{declare_inherit_function(property_id)}}
 {
     {% if property.svg %}
     {{set_value(property)}}(state.parentStyle()->svgStyle().{{property.getter}}());
     {% elif property.font %}
     {{set_value(property)}}(state.parentFontDescription().{{property.getter}}());
     {% else %}
     {{set_value(property)}}(state.parentStyle()->{{property.getter}}());
     {% endif %}
+    {% if property.independent %}
+    {{set_is_inherited(property)}}(false);
+    {% endif %}
 }
 
 {% endif %}
 {% if not property.custom_value %}
 {{declare_value_function(property_id)}}
 {
     {{convert_and_set_value(property)}}
+    {% if property.independent %}
+    {{set_is_inherited(property)}}(false);
+    {% endif %}
 }
 
 {% endif %}
 {% endfor %}
 
 {% macro apply_animation(property_id, attribute, animation) %}
 {% set vector = attribute|lower_first + "List()" %}
 {{declare_initial_function(property_id)}}
 {
     CSS{{animation}}Data& data = state.style()->access{{animation}}s();
@@ skipping 442 matching lines @@
         paintType = url.isEmpty() ? SVG_PAINTTYPE_RGBCOLOR : SVG_PAINTTYPE_URI_RGBCOLOR;
     }
     {{set_value(property)}}(paintType, color, url,
         state.applyPropertyToRegularStyle(),
         state.applyPropertyToVisitedLinkStyle());
 }
 {% endmacro %}
 {{apply_svg_paint('CSSPropertyFill', 'FillPaint')}}
 {{apply_svg_paint('CSSPropertyStroke', 'StrokePaint')}}
 } // namespace blink