Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_style_builder.py

Issue 2117143003: Add a fast-path for independent inherited properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computedstyle_cleanup_rename_final_member_fields
Patch Set: Added useful sizeof check comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (C) 2013 Google Inc. All rights reserved. 2 # Copyright (C) 2013 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 property[key] = value 52 property[key] = value
53 53
54 for property in self._properties.values(): 54 for property in self._properties.values():
55 upper_camel = property['upper_camel_name'] 55 upper_camel = property['upper_camel_name']
56 set_if_none(property, 'name_for_methods', upper_camel.replace('Webki t', '')) 56 set_if_none(property, 'name_for_methods', upper_camel.replace('Webki t', ''))
57 name = property['name_for_methods'] 57 name = property['name_for_methods']
58 simple_type_name = str(property['type_name']).split('::')[-1] 58 simple_type_name = str(property['type_name']).split('::')[-1]
59 set_if_none(property, 'type_name', 'E' + name) 59 set_if_none(property, 'type_name', 'E' + name)
60 set_if_none(property, 'getter', lower_first(name) if simple_type_nam e != name else 'get' + name) 60 set_if_none(property, 'getter', lower_first(name) if simple_type_nam e != name else 'get' + name)
61 set_if_none(property, 'setter', 'set' + name) 61 set_if_none(property, 'setter', 'set' + name)
62 set_if_none(property, 'isInheritedSetter', 'set' + name + 'IsInherit ed')
esprehn 2016/07/19 03:46:26 is_inherited_setter, the rest of the names here ar
62 set_if_none(property, 'initial', 'initial' + name) 63 set_if_none(property, 'initial', 'initial' + name)
63 if property['custom_all']: 64 if property['custom_all']:
64 property['custom_initial'] = True 65 property['custom_initial'] = True
65 property['custom_inherit'] = True 66 property['custom_inherit'] = True
66 property['custom_value'] = True 67 property['custom_value'] = True
67 property['should_declare_functions'] = not property['use_handlers_fo r'] and not property['longhands'] \ 68 property['should_declare_functions'] = not property['use_handlers_fo r'] and not property['longhands'] \
68 and not property['direction_aware'] and not property['builder_sk ip'] \ 69 and not property['direction_aware'] and not property['builder_sk ip'] \
69 and not property['descriptor_only'] 70 and not property['descriptor_only']
70 71
71 @template_expander.use_jinja('StyleBuilderFunctions.h.tmpl', 72 @template_expander.use_jinja('StyleBuilderFunctions.h.tmpl',
(...skipping 12 matching lines...) Expand all
84 85
85 @template_expander.use_jinja('StyleBuilder.cpp.tmpl', filters=filters) 86 @template_expander.use_jinja('StyleBuilder.cpp.tmpl', filters=filters)
86 def generate_style_builder(self): 87 def generate_style_builder(self):
87 return { 88 return {
88 'properties': self._properties, 89 'properties': self._properties,
89 } 90 }
90 91
91 92
92 if __name__ == '__main__': 93 if __name__ == '__main__':
93 in_generator.Maker(StyleBuilderWriter).main(sys.argv) 94 in_generator.Maker(StyleBuilderWriter).main(sys.argv)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698