Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211713002: Issue 17775. Semantic highlighting for function type alias. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
messick
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -10 lines) Patch
M editor/tools/plugins/com.google.dart.tools.deploy/mappings/com.google.dart.tools.ui.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/black-pastel.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/dartboard.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/debugging.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/default.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/frontenddev.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/gedit-original-oblivion.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/havenjark.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/hotpink.xml View 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/inkpot.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/minimal.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/monokai.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/mr.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/nightlion-aptana-theme.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/notepad++-like.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml View 1 chunk +1 line, -0 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/obsidian.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/pastel.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/rainbow.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/recogneyes.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/retta.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/roboticket.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/schuss.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/sublime-text-2.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/sunburst.xml View 1 chunk +1 line, -0 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/tango.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/vibrantink.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/wombat.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/themes/zenburn.xml View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditorMessages.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditorMessages.properties View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightings.java View 6 chunks +32 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/SemanticHighlightingTest.java View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 9 months ago (2014-03-25 20:53:48 UTC) #1
messick
lgtm https://codereview.chromium.org/211713002/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml File editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml (right): https://codereview.chromium.org/211713002/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml#newcode23 editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml:23: <functionTypeAlias color="#D25252" bold="false" underline="false" strikethrough="false" /> Do you ...
6 years, 9 months ago (2014-03-25 21:20:58 UTC) #2
scheglov
https://codereview.chromium.org/211713002/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml File editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml (right): https://codereview.chromium.org/211713002/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml#newcode23 editor/tools/plugins/com.google.dart.tools.deploy/themes/oblivion.xml:23: <functionTypeAlias color="#D25252" bold="false" underline="false" strikethrough="false" /> On 2014/03/25 21:20:59, ...
6 years, 9 months ago (2014-03-25 21:24:30 UTC) #3
scheglov
6 years, 9 months ago (2014-03-25 21:32:53 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r34392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698