Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117033002:
Prevent Add Exception from showing on the All Sites list. (Closed)
|
Created:
4 years, 5 months ago by Finnur Modified:
4 years, 5 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrevent Add Exception from showing on the All Sites list.
BUG=625598, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/29a171d38c0b053d35306560263073f8f7988ebc
Cr-Commit-Position: refs/heads/master@{#404118}
Patch Set 1 #
Total comments: 2
Patch Set 2 : git branch #Messages
Total messages: 17 (9 generated)
Description was changed from ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 ========== to ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
finnur@chromium.org changed reviewers: + tommycli@chromium.org
lgtm
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2117033002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_list.html (right): https://codereview.chromium.org/2117033002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_list.html:85: <div class="button-container" hidden$="[[allSites]]"> nit: it may be worthwhile to use dom-if instead of hidden here because <paper-button> has a lot of elements used to implement it (it's heavier than you think)
Description was changed from ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dbeam@chromium.org changed reviewers: - dbeam@chromium.org
https://codereview.chromium.org/2117033002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_list.html (right): https://codereview.chromium.org/2117033002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_list.html:85: <div class="button-container" hidden$="[[allSites]]"> Fair enough. Done. Checking in.
The CQ bit was checked by finnur@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2117033002/#ps20001 (title: "git branch")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Prevent Add Exception from showing on the All Sites list. BUG=625598, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/29a171d38c0b053d35306560263073f8f7988ebc Cr-Commit-Position: refs/heads/master@{#404118} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/29a171d38c0b053d35306560263073f8f7988ebc Cr-Commit-Position: refs/heads/master@{#404118} |
