Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2117003002: [X87] [wasm] Fix one V8 x87 code generation bug in TurboFan compiler. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [wasm] Fix one V8 x87 code generation bug in TurboFan compiler. The CL #37448 (https://codereview.chromium.org/2105313002) exposed one hidden bug in x87 turbofan compiler's code generation. This CL fixed that bugs. BUG= Committed: https://crrev.com/a21725c5d862ffd3096a7ac9d6e3ebac07bb8160 Cr-Commit-Position: refs/heads/master@{#37494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 09:03:44 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-04 09:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117003002/1
4 years, 5 months ago (2016-07-04 09:08:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 09:35:09 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 09:38:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a21725c5d862ffd3096a7ac9d6e3ebac07bb8160
Cr-Commit-Position: refs/heads/master@{#37494}

Powered by Google App Engine
This is Rietveld 408576698