Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: net/spdy/spdy_session_pool_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session_pool_unittest.cc
diff --git a/net/spdy/spdy_session_pool_unittest.cc b/net/spdy/spdy_session_pool_unittest.cc
index 329747de6a6936619fff941e693b6b2f5c9d7b33..66c71c3a12fcd8eebf665ae2f6769301625723d6 100644
--- a/net/spdy/spdy_session_pool_unittest.cc
+++ b/net/spdy/spdy_session_pool_unittest.cc
@@ -341,6 +341,7 @@ void SpdySessionPoolTest::RunIPPoolingTest(
};
session_deps_.host_resolver->set_synchronous_mode(true);
+ std::unique_ptr<HostResolver::Request> request[arraysize(test_hosts)];
for (size_t i = 0; i < arraysize(test_hosts); i++) {
session_deps_.host_resolver->rules()->AddIPLiteralRule(
test_hosts[i].name, test_hosts[i].iplist, std::string());
@@ -348,12 +349,9 @@ void SpdySessionPoolTest::RunIPPoolingTest(
// This test requires that the HostResolver cache be populated. Normal
// code would have done this already, but we do it manually.
HostResolver::RequestInfo info(HostPortPair(test_hosts[i].name, kTestPort));
- session_deps_.host_resolver->Resolve(info,
- DEFAULT_PRIORITY,
- &test_hosts[i].addresses,
- CompletionCallback(),
- NULL,
- BoundNetLog());
+ session_deps_.host_resolver->Resolve(
+ info, DEFAULT_PRIORITY, &test_hosts[i].addresses, CompletionCallback(),
+ &request[i], BoundNetLog());
// Setup a SpdySessionKey
test_hosts[i].key = SpdySessionKey(

Powered by Google App Engine
This is Rietveld 408576698