net/quic/quic_network_transaction_unittest.cc - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_network_transaction_unittest.cc

diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc

index e44fff26ea66493b1bfc1cd0c33600741c3cb69a..7902832c15278e08aa69060d48386007004188b3 100644

--- a/net/quic/quic_network_transaction_unittest.cc

+++ b/net/quic/quic_network_transaction_unittest.cc

@@ -1145,8 +1145,9 @@ TEST_P(QuicNetworkTransactionTest, GoAwayWithConnectionMigrationOnPortsOnly) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

session_->quic_stream_factory()->set_require_confirmation(true);

@@ -1691,8 +1692,9 @@ TEST_P(QuicNetworkTransactionTest, ZeroRTTWithNoHttpRace) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

AddHangingNonAlternateProtocolSocketData();

CreateSession();

@@ -1726,8 +1728,9 @@ TEST_P(QuicNetworkTransactionTest, ZeroRTTWithProxy) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

request_.url = GURL("http://mail.example.org/");

CreateSession();

@@ -1762,8 +1765,9 @@ TEST_P(QuicNetworkTransactionTest, ZeroRTTWithConfirmationRequired) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

session_->quic_stream_factory()->set_require_confirmation(true);

@@ -1808,8 +1812,9 @@ TEST_P(QuicNetworkTransactionTest,

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

session_->quic_stream_factory()->set_require_confirmation(true);

@@ -1863,8 +1868,9 @@ TEST_P(QuicNetworkTransactionTest,

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

session_->quic_stream_factory()->set_require_confirmation(true);

@@ -1914,8 +1920,9 @@ TEST_P(QuicNetworkTransactionTest, RstSteamErrorHandling) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

session_->quic_stream_factory()->set_require_confirmation(true);

@@ -1970,8 +1977,9 @@ TEST_P(QuicNetworkTransactionTest, RstSteamBeforeHeaders) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

session_->quic_stream_factory()->set_require_confirmation(true);

@@ -2198,8 +2206,9 @@ TEST_P(QuicNetworkTransactionTest, ConnectionCloseDuringConnect) {

"");

HostResolver::RequestInfo info(HostPortPair("mail.example.org", 443));

AddressList address;

+ std::unique_ptr<HostResolver::Request> request;

host_resolver_.Resolve(info, DEFAULT_PRIORITY, &address, CompletionCallback(),

- nullptr, net_log_.bound());

+ &request, net_log_.bound());

CreateSession();

AddQuicAlternateProtocolMapping(MockCryptoClientStream::ZERO_RTT);

« net/proxy/proxy_resolver_v8_tracing.cc ('K') | « net/proxy/proxy_service_mojo_unittest.cc ('k') | net/socket/socks5_client_socket_unittest.cc » ('j') | no next file with comments »